Issue 23697002: Implement proper map checks of captured objects.

Issue 23697002: Implement proper map checks of captured objects. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement proper map checks of captured objects. R=verwaest@chromium.org TEST=mjsunit/compiler/escape-analysis Committed: http://code.google.com/p/v8/source/detail?r=16403

Patch Set 2 : Ported to other architectures. #

Total comments: 4

Patch Set 3 : Addressed comments by Toon Verwaest. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -83 lines)			Patch
M	src/arm/lithium-arm.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/hydrogen.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/hydrogen-escape-analysis.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-escape-analysis.cc	View	1 2	6 chunks	+25 lines, -9 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2	5 chunks	+29 lines, -15 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/compiler/escape-analysis.js	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nits https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc File src/hydrogen-escape-analysis.cc (right): https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc#newcode129 src/hydrogen-escape-analysis.cc:129: HCapturedObject* state, HCheckMaps* mapcheck) { Syntax ...

7 years, 3 months ago (2013-08-28 13:29:30 UTC) #2

Michael Starzinger

Thanks. Comments addressed. Landing. https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc File src/hydrogen-escape-analysis.cc (right): https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc#newcode129 src/hydrogen-escape-analysis.cc:129: HCapturedObject* state, HCheckMaps* mapcheck) { ...

7 years, 3 months ago (2013-08-28 13:53:15 UTC) #3

Michael Starzinger

7 years, 3 months ago (2013-08-28 14:17:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r16403 (presubmit successful).

Expand Messages | Collapse Messages