Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 23697002: Implement proper map checks of captured objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1420 matching lines...) Expand 10 before | Expand all | Expand 10 after
1431 void HCheckMaps::PrintDataTo(StringStream* stream) { 1431 void HCheckMaps::PrintDataTo(StringStream* stream) {
1432 value()->PrintNameTo(stream); 1432 value()->PrintNameTo(stream);
1433 stream->Add(" [%p", *map_set()->first()); 1433 stream->Add(" [%p", *map_set()->first());
1434 for (int i = 1; i < map_set()->length(); ++i) { 1434 for (int i = 1; i < map_set()->length(); ++i) {
1435 stream->Add(",%p", *map_set()->at(i)); 1435 stream->Add(",%p", *map_set()->at(i));
1436 } 1436 }
1437 stream->Add("]%s", CanOmitMapChecks() ? "(omitted)" : ""); 1437 stream->Add("]%s", CanOmitMapChecks() ? "(omitted)" : "");
1438 } 1438 }
1439 1439
1440 1440
1441 void HCheckFunction::PrintDataTo(StringStream* stream) { 1441 void HCheckValue::PrintDataTo(StringStream* stream) {
1442 value()->PrintNameTo(stream); 1442 value()->PrintNameTo(stream);
1443 stream->Add(" %p", *target()); 1443 stream->Add(" ");
1444 object()->ShortPrint(stream);
1444 } 1445 }
1445 1446
1446 1447
1447 HValue* HCheckFunction::Canonicalize() { 1448 HValue* HCheckValue::Canonicalize() {
1448 return (value()->IsConstant() && 1449 return (value()->IsConstant() &&
1449 HConstant::cast(value())->UniqueValueIdsMatch(target_unique_id_)) 1450 HConstant::cast(value())->UniqueValueIdsMatch(object_unique_id_))
1450 ? NULL 1451 ? NULL
1451 : this; 1452 : this;
1452 } 1453 }
1453 1454
1454 1455
1455 const char* HCheckInstanceType::GetCheckName() { 1456 const char* HCheckInstanceType::GetCheckName() {
1456 switch (check_) { 1457 switch (check_) {
1457 case IS_SPEC_OBJECT: return "object"; 1458 case IS_SPEC_OBJECT: return "object";
1458 case IS_JS_ARRAY: return "array"; 1459 case IS_JS_ARRAY: return "array";
1459 case IS_STRING: return "string"; 1460 case IS_STRING: return "string";
(...skipping 2535 matching lines...) Expand 10 before | Expand all | Expand 10 after
3995 ASSERT(HasAstId()); 3996 ASSERT(HasAstId());
3996 } 3997 }
3997 3998
3998 3999
3999 void HCheckHeapObject::Verify() { 4000 void HCheckHeapObject::Verify() {
4000 HInstruction::Verify(); 4001 HInstruction::Verify();
4001 ASSERT(HasNoUses()); 4002 ASSERT(HasNoUses());
4002 } 4003 }
4003 4004
4004 4005
4005 void HCheckFunction::Verify() { 4006 void HCheckValue::Verify() {
4006 HInstruction::Verify(); 4007 HInstruction::Verify();
4007 ASSERT(HasNoUses()); 4008 ASSERT(HasNoUses());
4008 } 4009 }
4009 4010
4010 #endif 4011 #endif
4011 4012
4012 4013
4013 HObjectAccess HObjectAccess::ForFixedArrayHeader(int offset) { 4014 HObjectAccess HObjectAccess::ForFixedArrayHeader(int offset) {
4014 ASSERT(offset >= 0); 4015 ASSERT(offset >= 0);
4015 ASSERT(offset < FixedArray::kHeaderSize); 4016 ASSERT(offset < FixedArray::kHeaderSize);
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
4165 break; 4166 break;
4166 case kExternalMemory: 4167 case kExternalMemory:
4167 stream->Add("[external-memory]"); 4168 stream->Add("[external-memory]");
4168 break; 4169 break;
4169 } 4170 }
4170 4171
4171 stream->Add("@%d", offset()); 4172 stream->Add("@%d", offset());
4172 } 4173 }
4173 4174
4174 } } // namespace v8::internal 4175 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698