Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 23697002: Implement proper map checks of captured objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1992 matching lines...) Expand 10 before | Expand all | Expand 10 after
2003 } 2003 }
2004 2004
2005 2005
2006 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) { 2006 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) {
2007 LOperand* value = UseRegisterAtStart(instr->value()); 2007 LOperand* value = UseRegisterAtStart(instr->value());
2008 LInstruction* result = new(zone()) LCheckInstanceType(value); 2008 LInstruction* result = new(zone()) LCheckInstanceType(value);
2009 return AssignEnvironment(result); 2009 return AssignEnvironment(result);
2010 } 2010 }
2011 2011
2012 2012
2013 LInstruction* LChunkBuilder::DoCheckFunction(HCheckFunction* instr) { 2013 LInstruction* LChunkBuilder::DoCheckValue(HCheckValue* instr) {
2014 LOperand* value = UseRegisterAtStart(instr->value()); 2014 LOperand* value = UseRegisterAtStart(instr->value());
2015 return AssignEnvironment(new(zone()) LCheckFunction(value)); 2015 return AssignEnvironment(new(zone()) LCheckValue(value));
2016 } 2016 }
2017 2017
2018 2018
2019 LInstruction* LChunkBuilder::DoCheckMaps(HCheckMaps* instr) { 2019 LInstruction* LChunkBuilder::DoCheckMaps(HCheckMaps* instr) {
2020 LOperand* value = NULL; 2020 LOperand* value = NULL;
2021 if (!instr->CanOmitMapChecks()) { 2021 if (!instr->CanOmitMapChecks()) {
2022 value = UseRegisterAtStart(instr->value()); 2022 value = UseRegisterAtStart(instr->value());
2023 if (instr->has_migration_target()) info()->MarkAsDeferredCalling(); 2023 if (instr->has_migration_target()) info()->MarkAsDeferredCalling();
2024 } 2024 }
2025 LCheckMaps* result = new(zone()) LCheckMaps(value); 2025 LCheckMaps* result = new(zone()) LCheckMaps(value);
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
2573 2573
2574 2574
2575 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2575 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2576 LOperand* object = UseRegister(instr->object()); 2576 LOperand* object = UseRegister(instr->object());
2577 LOperand* index = UseRegister(instr->index()); 2577 LOperand* index = UseRegister(instr->index());
2578 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2578 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2579 } 2579 }
2580 2580
2581 2581
2582 } } // namespace v8::internal 2582 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698