src/x64/lithium-codegen-x64.cc - Issue 23697002: Implement proper map checks of captured objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 23697002: Implement proper map checks of captured objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 85f025594f9cfb6e7e533ab872a2ed23c51a1ed2..04133b7acf4046db6c9be801757ce33ee2755557 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -4889,10 +4889,10 @@ void LCodeGen::DoCheckInstanceType(LCheckInstanceType* instr) {

}

-void LCodeGen::DoCheckFunction(LCheckFunction* instr) {

+void LCodeGen::DoCheckValue(LCheckValue* instr) {

- Handle<JSFunction> target = instr->hydrogen()->target();

- __ CmpHeapObject(reg, target);

+ Handle<HeapObject> object = instr->hydrogen()->object();

+ __ CmpHeapObject(reg, object);

DeoptimizeIf(not_equal, instr->environment());

}

« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-x64.h » ('j') | no next file with comments »