Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 23697002: Implement proper map checks of captured objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5774 matching lines...) Expand 10 before | Expand all | Expand 10 after
5785 } else { 5785 } else {
5786 __ movzx_b(temp, FieldOperand(temp, Map::kInstanceTypeOffset)); 5786 __ movzx_b(temp, FieldOperand(temp, Map::kInstanceTypeOffset));
5787 __ and_(temp, mask); 5787 __ and_(temp, mask);
5788 __ cmp(temp, tag); 5788 __ cmp(temp, tag);
5789 DeoptimizeIf(not_equal, instr->environment()); 5789 DeoptimizeIf(not_equal, instr->environment());
5790 } 5790 }
5791 } 5791 }
5792 } 5792 }
5793 5793
5794 5794
5795 void LCodeGen::DoCheckFunction(LCheckFunction* instr) { 5795 void LCodeGen::DoCheckValue(LCheckValue* instr) {
5796 Handle<JSFunction> target = instr->hydrogen()->target(); 5796 Handle<HeapObject> object = instr->hydrogen()->object();
5797 if (instr->hydrogen()->target_in_new_space()) { 5797 if (instr->hydrogen()->object_in_new_space()) {
5798 Register reg = ToRegister(instr->value()); 5798 Register reg = ToRegister(instr->value());
5799 Handle<Cell> cell = isolate()->factory()->NewCell(target); 5799 Handle<Cell> cell = isolate()->factory()->NewCell(object);
5800 __ cmp(reg, Operand::ForCell(cell)); 5800 __ cmp(reg, Operand::ForCell(cell));
5801 } else { 5801 } else {
5802 Operand operand = ToOperand(instr->value()); 5802 Operand operand = ToOperand(instr->value());
5803 __ cmp(operand, target); 5803 __ cmp(operand, object);
5804 } 5804 }
5805 DeoptimizeIf(not_equal, instr->environment()); 5805 DeoptimizeIf(not_equal, instr->environment());
5806 } 5806 }
5807 5807
5808 5808
5809 void LCodeGen::DoDeferredInstanceMigration(LCheckMaps* instr, Register object) { 5809 void LCodeGen::DoDeferredInstanceMigration(LCheckMaps* instr, Register object) {
5810 { 5810 {
5811 PushSafepointRegistersScope scope(this); 5811 PushSafepointRegistersScope scope(this);
5812 __ push(object); 5812 __ push(object);
5813 __ xor_(esi, esi); 5813 __ xor_(esi, esi);
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
6550 FixedArray::kHeaderSize - kPointerSize)); 6550 FixedArray::kHeaderSize - kPointerSize));
6551 __ bind(&done); 6551 __ bind(&done);
6552 } 6552 }
6553 6553
6554 6554
6555 #undef __ 6555 #undef __
6556 6556
6557 } } // namespace v8::internal 6557 } } // namespace v8::internal
6558 6558
6559 #endif // V8_TARGET_ARCH_IA32 6559 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698