Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: src/hydrogen-escape-analysis.h

Issue 23697002: Implement proper map checks of captured objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-escape-analysis.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 void PerformScalarReplacement(); 56 void PerformScalarReplacement();
57 void AnalyzeDataFlow(HInstruction* instr); 57 void AnalyzeDataFlow(HInstruction* instr);
58 58
59 HCapturedObject* NewState(HInstruction* prev); 59 HCapturedObject* NewState(HInstruction* prev);
60 HCapturedObject* NewStateForAllocation(HInstruction* prev); 60 HCapturedObject* NewStateForAllocation(HInstruction* prev);
61 HCapturedObject* NewStateForLoopHeader(HInstruction* prev, HCapturedObject*); 61 HCapturedObject* NewStateForLoopHeader(HInstruction* prev, HCapturedObject*);
62 HCapturedObject* NewStateCopy(HInstruction* prev, HCapturedObject* state); 62 HCapturedObject* NewStateCopy(HInstruction* prev, HCapturedObject* state);
63 63
64 HPhi* NewPhiAndInsert(HBasicBlock* block, HValue* incoming_value, int index); 64 HPhi* NewPhiAndInsert(HBasicBlock* block, HValue* incoming_value, int index);
65 65
66 HValue* NewMapCheckAndInsert(HCapturedObject* state, HCheckMaps* mapcheck);
67
66 HCapturedObject* StateAt(HBasicBlock* block) { 68 HCapturedObject* StateAt(HBasicBlock* block) {
67 return block_states_.at(block->block_id()); 69 return block_states_.at(block->block_id());
68 } 70 }
69 71
70 void SetStateAt(HBasicBlock* block, HCapturedObject* state) { 72 void SetStateAt(HBasicBlock* block, HCapturedObject* state) {
71 block_states_.Set(block->block_id(), state); 73 block_states_.Set(block->block_id(), state);
72 } 74 }
73 75
74 // List of allocations captured during collection phase. 76 // List of allocations captured during collection phase.
75 ZoneList<HInstruction*> captured_; 77 ZoneList<HInstruction*> captured_;
76 78
77 // Number of captured objects on which scalar replacement was done. 79 // Number of captured objects on which scalar replacement was done.
78 int number_of_objects_; 80 int number_of_objects_;
79 81
80 // Number of scalar values tracked during scalar replacement phase. 82 // Number of scalar values tracked during scalar replacement phase.
81 int number_of_values_; 83 int number_of_values_;
82 int cumulative_values_; 84 int cumulative_values_;
83 85
84 // Map of block IDs to the data-flow state at block entry during the 86 // Map of block IDs to the data-flow state at block entry during the
85 // scalar replacement phase. 87 // scalar replacement phase.
86 ZoneList<HCapturedObject*> block_states_; 88 ZoneList<HCapturedObject*> block_states_;
87 }; 89 };
88 90
89 91
90 } } // namespace v8::internal 92 } } // namespace v8::internal
91 93
92 #endif // V8_HYDROGEN_ESCAPE_ANALYSIS_H_ 94 #endif // V8_HYDROGEN_ESCAPE_ANALYSIS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-escape-analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698