Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings (Closed)

Created:
4 years, 2 months ago by peria
Modified:
4 years, 2 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, Dirk Pranke, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a redundant option write-file-if-only-changed in bindings It is always set on everywhere the option is used for >3 years, and it means we have no hidden dependencies through generated files. BUG=650150 Committed: https://crrev.com/8db1c398f8456c3d0342b97a15747d1cf2ae994c Cr-Commit-Position: refs/heads/master@{#421482}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -79 lines) Patch
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_global_objects.py View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/generate_event_interfaces.py View 4 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py View 3 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py View 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/idl_compiler.py View 1 2 8 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 6 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/utilities.py View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 1 2 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
peria
PTL
4 years, 2 months ago (2016-09-27 07:03:46 UTC) #5
haraken
LGTM
4 years, 2 months ago (2016-09-27 07:24:58 UTC) #6
bashi
lgtm; nice clean-up!
4 years, 2 months ago (2016-09-27 07:26:20 UTC) #7
Yuki
LGTM.
4 years, 2 months ago (2016-09-27 07:40:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367303002/20001
4 years, 2 months ago (2016-09-28 06:48:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/76339) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-28 06:50:35 UTC) #12
peria
Rebase
4 years, 2 months ago (2016-09-28 06:54:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367303002/40001
4 years, 2 months ago (2016-09-28 06:57:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 08:28:53 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 08:31:04 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8db1c398f8456c3d0342b97a15747d1cf2ae994c
Cr-Commit-Position: refs/heads/master@{#421482}

Powered by Google App Engine
This is Rietveld 408576698