third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py - Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py

Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py ('k') | third_party/WebKit/Source/bindings/scripts/idl_compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py

diff --git a/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py b/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py

index d3a49dffa231f0891cc2972ab2e4de723088fd0b..0cc923ca24e6e41dcdfc0e35d47b085b0a4a6c0e 100755

--- a/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py

+++ b/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py

@@ -42,7 +42,6 @@ def parse_options():

parser = OptionParser(usage=usage)

parser.add_option('--idl-files-list', help="a text file containing the IDL file paths, so the command line doesn't exceed OS length limits.")

parser.add_option('--gyp-format-list', default=False, action='store_true', help="if specified, idl-files-list is newline separated. When unspecified, it's formatted as a Posix command line.")

- parser.add_option('--write-file-only-if-changed', type='int', help='if true, do not write an output file if it would be identical to the existing one, which avoids unnecessary rebuilds in ninja')

parser.add_option('--output')

options, args = parser.parse_args()

@@ -50,9 +49,6 @@ def parse_options():

parser.error('Must specify output file using --output.')

if options.idl_files_list is None:

parser.error('Must specify a list of IDL files using --idl-files-list.')

- if options.write_file_only_if_changed is None:

- parser.error('Must specify whether file is only written if changed using --write-file-only-if-changed.')

- options.write_file_only_if_changed = bool(options.write_file_only_if_changed)

return options

@@ -103,8 +99,7 @@ def main():

'\n'.join(includes),

'\n'.join(initialize_calls))

- write_file(content, options.output,

- only_if_changed=options.write_file_only_if_changed)

+ write_file(content, options.output)

if __name__ == '__main__':