Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py
diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py
index ed5c9df2692c11303a2931ca4f218937f6cce7c3..6dd0e85f749ab80a6bea83a7d6159dc1027a92ea 100755
--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py
+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py
@@ -113,13 +113,8 @@ class IdlInterfaceFileNotFoundError(Exception):
def parse_options():
usage = 'Usage: %prog [InfoIndividual.pickle]... [Info.pickle]'
parser = optparse.OptionParser(usage=usage)
- parser.add_option('--write-file-only-if-changed', type='int', help='if true, do not write an output file if it would be identical to the existing one, which avoids unnecessary rebuilds in ninja')
- options, args = parser.parse_args()
- if options.write_file_only_if_changed is None:
- parser.error('Must specify whether file is only written if changed using --write-file-only-if-changed.')
- options.write_file_only_if_changed = bool(options.write_file_only_if_changed)
- return options, args
+ return parser.parse_args()
def dict_of_dicts_of_lists_update_or_append(existing, other):
@@ -315,15 +310,13 @@ def compute_interfaces_info_overall(info_individuals):
################################################################################
def main():
- options, args = parse_options()
+ _, args = parse_options()
# args = Input1, Input2, ..., Output
interfaces_info_filename = args.pop()
info_individuals = read_pickle_files(args)
compute_interfaces_info_overall(info_individuals)
- write_pickle_file(interfaces_info_filename,
- interfaces_info,
- options.write_file_only_if_changed)
+ write_pickle_file(interfaces_info_filename, interfaces_info)
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698