Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py

Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/utilities.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
index dd300bc9cc69dce55c500880a4acb8e24ac0938a..354f5568556e2aaad1165504bb75cbd3b89088b2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
@@ -274,7 +274,7 @@ def bindings_tests(output_directory, verbose):
output_dir=output_directory, target_component=component)
outputs = generator.generate_code()
for output_path, output_code in outputs:
- write_file(output_code, output_path, only_if_changed=True)
+ write_file(output_code, output_path)
def generate_callback_function_impl(output_directory, component):
generator = CodeGeneratorCallbackFunction(
@@ -282,7 +282,7 @@ def bindings_tests(output_directory, verbose):
output_dir=output_directory, target_component=component)
outputs = generator.generate_code()
for output_path, output_code in outputs:
- write_file(output_code, output_path, only_if_changed=True)
+ write_file(output_code, output_path)
try:
generate_interface_dependencies()
@@ -297,7 +297,6 @@ def bindings_tests(output_directory, verbose):
idl_compiler = IdlCompilerV8(
output_dir,
info_provider=component_info_providers[component],
- only_if_changed=True,
target_component=component)
if component == 'core':
partial_interface_output_dir = os.path.join(output_directory,
@@ -307,14 +306,13 @@ def bindings_tests(output_directory, verbose):
idl_partial_interface_compiler = IdlCompilerV8(
partial_interface_output_dir,
info_provider=component_info_providers['modules'],
- only_if_changed=True,
target_component='modules')
else:
idl_partial_interface_compiler = None
dictionary_impl_compiler = IdlCompilerDictionaryImpl(
output_dir, info_provider=component_info_providers[component],
- only_if_changed=True, target_component=component)
+ target_component=component)
idl_filenames = []
input_directory = os.path.join(test_input_directory, component)
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/utilities.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698