Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_global_objects.py

Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/compute_global_objects.py
diff --git a/third_party/WebKit/Source/bindings/scripts/compute_global_objects.py b/third_party/WebKit/Source/bindings/scripts/compute_global_objects.py
index 2e83e466ef0803abebed04b9343a8cedf623f623..9538f85ae981559f2db6e550c90d8dc01d8fb6a5 100755
--- a/third_party/WebKit/Source/bindings/scripts/compute_global_objects.py
+++ b/third_party/WebKit/Source/bindings/scripts/compute_global_objects.py
@@ -29,15 +29,11 @@ def parse_options():
usage = 'Usage: %prog [options] [GlobalObjectsComponent.pickle]... [GlobalObjects.pickle]'
parser = optparse.OptionParser(usage=usage)
parser.add_option('--idl-files-list', help='file listing IDL files')
- parser.add_option('--write-file-only-if-changed', type='int', help='if true, do not write an output file if it would be identical to the existing one, which avoids unnecessary rebuilds in ninja')
options, args = parser.parse_args()
if options.idl_files_list is None:
parser.error('Must specify a file listing IDL files using --idl-files-list.')
- if options.write_file_only_if_changed is None:
- parser.error('Must specify whether output files are only written if changed using --write-file-only-if-changed.')
- options.write_file_only_if_changed = bool(options.write_file_only_if_changed)
if not args:
parser.error('Must specify an output pickle filename as argument, '
'optionally preceeded by input pickle filenames.')
@@ -103,8 +99,7 @@ def main():
idl_files_to_interface_name_global_names(idl_files))
write_pickle_file(output_global_objects_filename,
- interface_name_global_names,
- options.write_file_only_if_changed)
+ interface_name_global_names)
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698