Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/scripts.gni

Issue 2367303002: [Bindings] Remove a redundant option write-file-if-only-changed in bindings (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/core/core_idl_files.gni") 5 import("//third_party/WebKit/Source/core/core_idl_files.gni")
6 import("//third_party/WebKit/Source/modules/modules_idl_files.gni") 6 import("//third_party/WebKit/Source/modules/modules_idl_files.gni")
7 7
8 bindings_scripts_dir = get_path_info(".", "abspath") 8 bindings_scripts_dir = get_path_info(".", "abspath")
9 bindings_scripts_output_dir = "$root_gen_dir/blink/bindings/scripts" 9 bindings_scripts_output_dir = "$root_gen_dir/blink/bindings/scripts"
10 10
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 response_file_contents = rebase_path(invoker.sources, root_build_dir) 77 response_file_contents = rebase_path(invoker.sources, root_build_dir)
78 args = [ 78 args = [
79 "--cache-directory", 79 "--cache-directory",
80 rebase_path(bindings_scripts_output_dir, root_build_dir), 80 rebase_path(bindings_scripts_output_dir, root_build_dir),
81 "--idl-files-list", 81 "--idl-files-list",
82 "{{response_file_name}}", 82 "{{response_file_name}}",
83 "--interfaces-info-file", 83 "--interfaces-info-file",
84 rebase_path(invoker.interfaces_info_file, root_build_dir), 84 rebase_path(invoker.interfaces_info_file, root_build_dir),
85 "--component-info-file", 85 "--component-info-file",
86 rebase_path(invoker.component_info_file, root_build_dir), 86 rebase_path(invoker.component_info_file, root_build_dir),
87 "--write-file-only-if-changed=1",
88 ] 87 ]
89 88
90 deps = [ "//third_party/WebKit/Source/bindings/scripts:cached_lex_yacc_table s" ] + invoker.deps 89 deps = [ "//third_party/WebKit/Source/bindings/scripts:cached_lex_yacc_table s" ] + invoker.deps
91 } 90 }
92 } 91 }
93 92
94 # Calls generate_event_interfaces 93 # Calls generate_event_interfaces
95 # 94 #
96 # Parameters: 95 # Parameters:
97 # sources = A list of IDL files to process. 96 # sources = A list of IDL files to process.
(...skipping 15 matching lines...) Expand all
113 outputs = [ 112 outputs = [
114 output_file, 113 output_file,
115 ] 114 ]
116 115
117 script = "//third_party/WebKit/Source/bindings/scripts/generate_event_interf aces.py" 116 script = "//third_party/WebKit/Source/bindings/scripts/generate_event_interf aces.py"
118 args = [ 117 args = [
119 "--event-idl-files-list", 118 "--event-idl-files-list",
120 rebase_path(idl_files_list, root_build_dir), 119 rebase_path(idl_files_list, root_build_dir),
121 "--event-interfaces-file", 120 "--event-interfaces-file",
122 rebase_path(output_file, root_build_dir), 121 rebase_path(output_file, root_build_dir),
123 "--write-file-only-if-changed=1", # Always true for Ninja.
124 ] 122 ]
125 123
126 if (defined(invoker.suffix)) { 124 if (defined(invoker.suffix)) {
127 args += [ 125 args += [
128 "--suffix", 126 "--suffix",
129 invoker.suffix, 127 invoker.suffix,
130 ] 128 ]
131 } 129 }
132 } 130 }
133 } 131 }
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 "$output_dir/V8{{source_name_part}}${output_name_suffix}.h", 176 "$output_dir/V8{{source_name_part}}${output_name_suffix}.h",
179 ] 177 ]
180 178
181 args = [ 179 args = [
182 "--cache-dir", 180 "--cache-dir",
183 rebase_path(bindings_scripts_output_dir, root_build_dir), 181 rebase_path(bindings_scripts_output_dir, root_build_dir),
184 "--output-dir", 182 "--output-dir",
185 rebase_path(output_dir, root_build_dir), 183 rebase_path(output_dir, root_build_dir),
186 "--info-dir", 184 "--info-dir",
187 rebase_path("$bindings_output_dir", root_build_dir), 185 rebase_path("$bindings_output_dir", root_build_dir),
188 "--write-file-only-if-changed=1", # Always true for Ninja.
189 "--target-component", 186 "--target-component",
190 invoker.target_component, 187 invoker.target_component,
191 "{{source}}", 188 "{{source}}",
192 ] 189 ]
193 190
194 public_deps = [ 191 public_deps = [
195 "//third_party/WebKit/Source/bindings/core:core_global_constructors_idls", 192 "//third_party/WebKit/Source/bindings/core:core_global_constructors_idls",
196 193
197 # FIXME: should be interfaces_info_core (w/o modules) 194 # FIXME: should be interfaces_info_core (w/o modules)
198 # http://crbug.com/358074 195 # http://crbug.com/358074
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 "--cache-dir", 232 "--cache-dir",
236 rebase_path(bindings_scripts_output_dir, root_build_dir), 233 rebase_path(bindings_scripts_output_dir, root_build_dir),
237 "--output-dir", 234 "--output-dir",
238 rebase_path(invoker.output_dir, root_build_dir), 235 rebase_path(invoker.output_dir, root_build_dir),
239 "--impl-output-dir", 236 "--impl-output-dir",
240 rebase_path(dictionary_impl_output_dir, root_build_dir), 237 rebase_path(dictionary_impl_output_dir, root_build_dir),
241 "--info-dir", 238 "--info-dir",
242 rebase_path("$bindings_output_dir", root_build_dir), 239 rebase_path("$bindings_output_dir", root_build_dir),
243 "--target-component", 240 "--target-component",
244 invoker.target_component, 241 invoker.target_component,
245 "--write-file-only-if-changed=1",
246 "--generate-impl", 242 "--generate-impl",
247 rebase_path(idl_files_list, root_build_dir), 243 rebase_path(idl_files_list, root_build_dir),
248 ] 244 ]
249 245
250 deps = [ 246 deps = [
251 # FIXME: should be interfaces_info_core (w/o modules) 247 # FIXME: should be interfaces_info_core (w/o modules)
252 # http://crbug.com/358074 248 # http://crbug.com/358074
253 "//third_party/WebKit/Source/bindings/core:interfaces_info_individual_core ", 249 "//third_party/WebKit/Source/bindings/core:interfaces_info_individual_core ",
254 "//third_party/WebKit/Source/bindings/modules:interfaces_info", 250 "//third_party/WebKit/Source/bindings/modules:interfaces_info",
255 "//third_party/WebKit/Source/bindings/modules:interfaces_info_individual_m odules", 251 "//third_party/WebKit/Source/bindings/modules:interfaces_info_individual_m odules",
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 idl_files_list, 302 idl_files_list,
307 ] + invoker.sources_generated + invoker.sources 303 ] + invoker.sources_generated + invoker.sources
308 304
309 outputs = [ 305 outputs = [
310 invoker.output_file, 306 invoker.output_file,
311 ] 307 ]
312 308
313 args = [ 309 args = [
314 "--idl-files-list", 310 "--idl-files-list",
315 rebase_path(idl_files_list, root_build_dir), 311 rebase_path(idl_files_list, root_build_dir),
316 "--write-file-only-if-changed=1", # Always true for Ninja.
317 "--", 312 "--",
318 ] 313 ]
319 args += rebase_path(invoker.sources_generated, root_build_dir) 314 args += rebase_path(invoker.sources_generated, root_build_dir)
320 args += [ rebase_path(invoker.output_file, root_build_dir) ] 315 args += [ rebase_path(invoker.output_file, root_build_dir) ]
321 316
322 deps = invoker.deps 317 deps = invoker.deps
323 } 318 }
324 } 319 }
325 320
326 # Calls the generate_global_constructors script. 321 # Calls the generate_global_constructors script.
(...skipping 19 matching lines...) Expand all
346 "//third_party/WebKit/Source/bindings/scripts/utilities.py", 341 "//third_party/WebKit/Source/bindings/scripts/utilities.py",
347 idl_files_list, 342 idl_files_list,
348 invoker.global_objects_file, 343 invoker.global_objects_file,
349 ] + invoker.sources 344 ] + invoker.sources
350 345
351 args = [ 346 args = [
352 "--idl-files-list", 347 "--idl-files-list",
353 rebase_path(idl_files_list, root_build_dir), 348 rebase_path(idl_files_list, root_build_dir),
354 "--global-objects-file", 349 "--global-objects-file",
355 rebase_path(invoker.global_objects_file, root_build_dir), 350 rebase_path(invoker.global_objects_file, root_build_dir),
356 "--write-file-only-if-changed=1", # Always true for Ninja.
357 "--", 351 "--",
358 ] 352 ]
359 353
360 output_dir = invoker.output_dir 354 output_dir = invoker.output_dir
361 component = invoker.component 355 component = invoker.component
362 356
363 # generate outputs from invoker.interfaces. 357 # generate outputs from invoker.interfaces.
364 output_idl_files = [] 358 output_idl_files = []
365 output_header_files = [] 359 output_header_files = []
366 foreach(interface, invoker.interfaces) { 360 foreach(interface, invoker.interfaces) {
367 args += [ interface ] 361 args += [ interface ]
368 output_idl_file = "$output_dir/${interface}${component}Constructors.idl" 362 output_idl_file = "$output_dir/${interface}${component}Constructors.idl"
369 args += [ rebase_path(output_idl_file, root_build_dir) ] 363 args += [ rebase_path(output_idl_file, root_build_dir) ]
370 output_idl_files += [ output_idl_file ] 364 output_idl_files += [ output_idl_file ]
371 output_header_files += 365 output_header_files +=
372 [ "$output_dir/${interface}${component}Constructors.h" ] 366 [ "$output_dir/${interface}${component}Constructors.h" ]
373 } 367 }
374 368
375 outputs = output_idl_files + output_header_files 369 outputs = output_idl_files + output_header_files
376 deps = invoker.deps 370 deps = invoker.deps
377 } 371 }
378 } 372 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/idl_compiler.py ('k') | third_party/WebKit/Source/bindings/scripts/utilities.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698