Stop aggregating texture/buffer access objects in GrFragmentProcessor parents.

Stop aggregating texture/buffer access objects in GrFragmentProcessor parents.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349243002

Committed: https://skia.googlesource.com/skia/+/b58a2b4919aa67ab5bab1d497f26671d704654b4

[bsalomon, 2016-09-23 19:49:45]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-09-26 13:13:18]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 13:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-09-26 13:27:23]

lgtm

https://codereview.chromium.org/2365943003/diff/20001/include/gpu/GrFragmentP...
File include/gpu/GrFragmentProcessor.h (right):

https://codereview.chromium.org/2365943003/diff/20001/include/gpu/GrFragmentP...
include/gpu/GrFragmentProcessor.h:146: class FPItemIter {
Was the removal of the "public SkNoncopyable" derivation intentional ?

https://codereview.chromium.org/2365943003/diff/20001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/2365943003/diff/20001/src/gpu/gl/GrGLProgram....
src/gpu/gl/GrGLProgram.cpp:113: this->bindTextures(*fp,
pipeline.getAllowSRGBInputs(), nextSamplerIdx);
?? re ','

https://codereview.chromium.org/2365943003/diff/20001/src/gpu/vk/GrVkPipeline...
File src/gpu/vk/GrVkPipelineState.cpp (right):

https://codereview.chromium.org/2365943003/diff/20001/src/gpu/vk/GrVkPipeline...
src/gpu/vk/GrVkPipelineState.cpp:209: fp = iter.next(), glslFP =
glslIter.next();
here too ...

[bsalomon, 2016-09-26 13:31:52]

https://codereview.chromium.org/2365943003/diff/20001/include/gpu/GrFragmentP...
File include/gpu/GrFragmentProcessor.h (right):

https://codereview.chromium.org/2365943003/diff/20001/include/gpu/GrFragmentP...
include/gpu/GrFragmentProcessor.h:146: class FPItemIter {
On 2016/09/26 13:27:22, robertphillips wrote:
> Was the removal of the "public SkNoncopyable" derivation intentional ?

No, readded.

https://codereview.chromium.org/2365943003/diff/20001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/2365943003/diff/20001/src/gpu/gl/GrGLProgram....
src/gpu/gl/GrGLProgram.cpp:113: this->bindTextures(*fp,
pipeline.getAllowSRGBInputs(), nextSamplerIdx);
On 2016/09/26 13:27:23, robertphillips wrote:
> ?? re ','

I thought it was just clearer that both the iterators were advanced together. I
can put them on separate lines with ; if you like.

[bsalomon, 2016-09-26 13:35:36]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-26 13:35:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2365943003/#ps60001
(title: "Readd base class, rebase")

[commit-bot: I haz the power, 2016-09-26 13:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 13:55:04]

Description was changed from

==========
Stop aggregating texture/buffer access objects in GrFragmentProcessor parents.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349243002
==========

to

==========
Stop aggregating texture/buffer access objects in GrFragmentProcessor parents.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349243002

Committed:
https://skia.googlesource.com/skia/+/b58a2b4919aa67ab5bab1d497f26671d704654b4
==========

[commit-bot: I haz the power, 2016-09-26 13:55:05]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b58a2b4919aa67ab5bab1d497f26671d704654b4