Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2358833002:
Update pixel test expectation and add new worker tests (Closed)
DescriptionUpdate pixel test expectation and add new worker tests
In the previous CL: https://codereview.chromium.org/2328463004/ where
the commit() function is implemented, we add a new pixel test and put its
expectation to fail. Now that the reference image has been generated on
all GPU waterfall bots, it is time to update the expectation.
This CL also adds a new test to make sure that WebGL's commit()
is behaving as expected on a worker thread.
BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05
Committed: https://crrev.com/03083077956acc232b34b1a51e13ffe4c1f139a2
Cr-Original-Commit-Position: refs/heads/master@{#420304}
Cr-Commit-Position: refs/heads/master@{#420379}
Patch Set 1 #Patch Set 2 : worker works #Patch Set 3 : include newly added file #
Total comments: 4
Patch Set 4 : address comments #Patch Set 5 : add 2d tests #Patch Set 6 : minor change in test description #
Total comments: 4
Patch Set 7 : back to PS4 #
Messages
Total messages: 42 (20 generated)
Description was changed from ========== Update pixel test expectation and add new tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds some new tests to ensure that 2D's commit() is behaving as expected. BUG=563852 ========== to ========== Update pixel test expectation and add new tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds some new tests to ensure that 2D's commit() is behaving as expected. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Update pixel test expectation and add new tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds some new tests to ensure that 2D's commit() is behaving as expected. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
xidachen@chromium.org changed reviewers: + bajones@chromium.org, junov@chromium.org, kbr@chromium.org, zmo@chromium.org
PTAL
https://codereview.chromium.org/2358833002/diff/40001/content/test/data/gpu/p... File content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html (right): https://codereview.chromium.org/2358833002/diff/40001/content/test/data/gpu/p... content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html:45: worker.postMessage({data: offscreenCanvas}, [offscreenCanvas]); 'data' is not a great name for this field. In fact, this could just be "worker.postMessage(offscreenCanvas, [offscreenCanvas]);" And above, you would access it as "e.data" rather than "e.data.data". https://codereview.chromium.org/2358833002/diff/40001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/pixel_expectations.py (right): https://codereview.chromium.org/2358833002/diff/40001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/pixel_expectations.py:36: self.Fail('Pixel.OffscreenCanvasWebGLRedBoxWorkerES3', ['mac'], bug=563852) What is going on here. Are the old tests passing now?
https://codereview.chromium.org/2358833002/diff/40001/content/test/data/gpu/p... File content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html (right): https://codereview.chromium.org/2358833002/diff/40001/content/test/data/gpu/p... content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html:45: worker.postMessage({data: offscreenCanvas}, [offscreenCanvas]); On 2016/09/21 17:23:21, Justin Novosad wrote: > 'data' is not a great name for this field. In fact, this could just be > "worker.postMessage(offscreenCanvas, [offscreenCanvas]);" And above, you would > access it as "e.data" rather than "e.data.data". Done. https://codereview.chromium.org/2358833002/diff/40001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/pixel_expectations.py (right): https://codereview.chromium.org/2358833002/diff/40001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/pixel_expectations.py:36: self.Fail('Pixel.OffscreenCanvasWebGLRedBoxWorkerES3', ['mac'], bug=563852) On 2016/09/21 17:23:21, Justin Novosad wrote: > What is going on here. Are the old tests passing now? Yes. The way pixel test works is like this: 1. Write a new test, mark it as failure, land the patch 2. GPU bots will run the test, generate reference images and store them on cloud. 3. Once all bots have generated the reference images, remove this failure entry. Because the bots will use the images stored on cloud as reference images. I checked the reference image, and the results on win, linux and android is as expected. But on mac it is giving me a black box on white background, instead of a green box on white background. I have to dig into that. Anyway, in my opinion, that should not necessary block this CL.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. Besides that, 2 new tests are added to test 2D's commit() flow. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
added some more test case for 2D rendering context, PTAL.
lgtm (not an OWNER in contenet/test)
lgtm on the deletion of tests in third_party/WebKit/LayoutTests and the added 2d commit tests.
The changes look OK in principle but it seems to me the 2D tests aren't what you expected. You can run these locally via run_gpu_test.py pixel --browser=release , and they'll produce results into src/content/test/data/gpu/generated -- can you try that and make sure they're what you expect, at least on your local machine? https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... File content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html (right): https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html:31: offscreen2d.commit(); This doesn't seem to do anything with the context -- shouldn't it be clearing it to green? https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... File content/test/data/gpu/pixel_offscreenCanvas_2D_commit_worker.html (right): https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... content/test/data/gpu/pixel_offscreenCanvas_2D_commit_worker.html:21: offscreen2d.commit(); Same here.
https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... File content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html (right): https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html:31: offscreen2d.commit(); On 2016/09/22 00:50:36, Ken Russell wrote: > This doesn't seem to do anything with the context -- shouldn't it be clearing it > to green? Sorry that this is confusing. I forgot to clarify: currently in 2D's commit(), the C++ implementation just submit a green SolidColor frame, and nothing else. So even if we do any kind of drawing in here, it won't show in the frame. I will have a new patch set ready to drop the tests for 2D case because the implementation is not completed yet. Once the implementation is all ready, we can then add the tests. Does that make sense?
https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... File content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html (right): https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html:31: offscreen2d.commit(); On 2016/09/22 00:58:15, xidachen wrote: > On 2016/09/22 00:50:36, Ken Russell wrote: > > This doesn't seem to do anything with the context -- shouldn't it be clearing > it > > to green? > > Sorry that this is confusing. I forgot to clarify: currently in 2D's commit(), > the C++ implementation just submit a green SolidColor frame, and nothing else. > So even if we do any kind of drawing in here, it won't show in the frame. > > I will have a new patch set ready to drop the tests for 2D case because the > implementation is not completed yet. Once the implementation is all ready, we > can then add the tests. Does that make sense? Yes, please either: 1) Remove the 2D canvas tests from this CL 2) Clear the context to green here (i.e., whatever the green SolidColor quad is doing under the hood). If you did this, then you could at least verify your implementation when you complete it, since it should have the same pixel results before and after. But I'm not sure you should assume that until you can test it so I think removing the tests would be better.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. Besides that, 2 new tests are added to test 2D's commit() flow. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2016/09/22 01:12:09, Ken Russell wrote: > https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... > File content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html (right): > > https://codereview.chromium.org/2358833002/diff/100001/content/test/data/gpu/... > content/test/data/gpu/pixel_offscreenCanvas_2D_commit_main.html:31: > offscreen2d.commit(); > On 2016/09/22 00:58:15, xidachen wrote: > > On 2016/09/22 00:50:36, Ken Russell wrote: > > > This doesn't seem to do anything with the context -- shouldn't it be > clearing > > it > > > to green? > > > > Sorry that this is confusing. I forgot to clarify: currently in 2D's commit(), > > the C++ implementation just submit a green SolidColor frame, and nothing else. > > So even if we do any kind of drawing in here, it won't show in the frame. > > > > I will have a new patch set ready to drop the tests for 2D case because the > > implementation is not completed yet. Once the implementation is all ready, we > > can then add the tests. Does that make sense? > > Yes, please either: > > 1) Remove the 2D canvas tests from this CL > 2) Clear the context to green here (i.e., whatever the green SolidColor quad is > doing under the hood). If you did this, then you could at least verify your > implementation when you complete it, since it should have the same pixel results > before and after. But I'm not sure you should assume that until you can test it > so I think removing the tests would be better. Thank you for your quick response. Yes, I agree that dropping the 2D tests is the best for now. In PS#7, I have removed all 2D tests. So this CL is only adding a test for WebGL's commit() on a worker thread. CL description is changed as well. PTAL.
Thanks for keeping things simple. LGTM
The CQ bit was checked by xidachen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xidachen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xlai@chromium.org, junov@chromium.org Link to the patchset: https://codereview.chromium.org/2358833002/#ps120001 (title: "back to PS4")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2359123002/ by ricea@chromium.org. The reason for reverting is: Appears to have broken pixel_tests on Win7 Release (NVIDIA) and Linux Release (NVIDIA) bots..
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2358803003/ by grunell@chromium.org. The reason for reverting is: Breaks pixel_tests on Linux Release (NVIDIA) and other bots. https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20%28NVIDI....
Message was sent while issue was closed.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304} ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304} ==========
The CQ bit was checked by xidachen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xidachen@chromium.org
The fix for the pixel test failure: https://codereview.chromium.org/2359193002/ has landed, and I see that all gpu bots have picked up the fix. I think it is safe to land this again.
The CQ bit was checked by xidachen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304} ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304} ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Cr-Commit-Position: refs/heads/master@{#420304} ========== to ========== Update pixel test expectation and add new worker tests In the previous CL: https://codereview.chromium.org/2328463004/ where the commit() function is implemented, we add a new pixel test and put its expectation to fail. Now that the reference image has been generated on all GPU waterfall bots, it is time to update the expectation. This CL also adds a new test to make sure that WebGL's commit() is behaving as expected on a worker thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 Committed: https://crrev.com/03083077956acc232b34b1a51e13ffe4c1f139a2 Cr-Original-Commit-Position: refs/heads/master@{#420304} Cr-Commit-Position: refs/heads/master@{#420379} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/03083077956acc232b34b1a51e13ffe4c1f139a2 Cr-Commit-Position: refs/heads/master@{#420379}
Message was sent while issue was closed.
On 2016/09/22 17:14:14, commit-bot: I haz the power wrote: > Committed patchset #7 (id:120001) I'm 100% sure the CQ didn't retry those try jobs, and it really should have. Filed http://crbug.com/649390 . Xida, please watch the bots and make sure the pixel test is passing reliably. Thanks. In particular please watch the trybots: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel... https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
Message was sent while issue was closed.
On 2016/09/22 17:22:52, Ken Russell wrote: > On 2016/09/22 17:14:14, commit-bot: I haz the power wrote: > > Committed patchset #7 (id:120001) > > I'm 100% sure the CQ didn't retry those try jobs, and it really should have. > Filed http://crbug.com/649390 . > > Xida, please watch the bots and make sure the pixel test is passing reliably. > Thanks. In particular please watch the trybots: > > https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... > https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel... > https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel... Thanks Ken. I have been watching the GPU bots on waterfall, all of them have picked up the new change, and things look fine. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
