Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2358803003: Revert of Update pixel test expectation and add new worker tests (Closed)

Created:
4 years, 3 months ago by Henrik Grunell
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update pixel test expectation and add new worker tests (patchset #7 id:120001 of https://codereview.chromium.org/2358833002/ ) Reason for revert: Breaks pixel_tests on Linux Release (NVIDIA) and other bots. https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20%28NVIDIA%29/builds/87008 Original issue's description: > Update pixel test expectation and add new worker tests > > In the previous CL: https://codereview.chromium.org/2328463004/ where > the commit() function is implemented, we add a new pixel test and put its > expectation to fail. Now that the reference image has been generated on > all GPU waterfall bots, it is time to update the expectation. > > This CL also adds a new test to make sure that WebGL's commit() > is behaving as expected on a worker thread. > > BUG=563852 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 > Cr-Commit-Position: refs/heads/master@{#420304} TBR=junov@chromium.org,kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -79 lines) Patch
D content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html View 1 chunk +0 lines, -68 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Henrik Grunell
Created Revert of Update pixel test expectation and add new worker tests
4 years, 3 months ago (2016-09-22 13:01:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358803003/1
4 years, 3 months ago (2016-09-22 13:01:49 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 13:02:24 UTC) #5 
Failed to apply patch for
content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html:
While running git rm
content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html;
  fatal: pathspec
'content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html' did not
match any files

Patch:  D   
content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
Index: content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
diff --git
a/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
b/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
deleted file mode 100644
index
d4a9ea713d881c86af13fffbb099c1210e6874b8..0000000000000000000000000000000000000000
--- a/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
+++ /dev/null
@@ -1,68 +0,0 @@
-<!DOCTYPE HTML>
-
-<!-- READ BEFORE UPDATING:
-If this test is updated make sure to increment the "revision" value of the
-associated test in content/test/gpu/page_sets/pixel_tests.py. This will ensure
-that the baseline images are regenerated on the next run.
--->
-
-<html>
-<head>
-<title>OffscreenCanvas commit flow on worker thread: red square on white
background.</title>
-<style type="text/css">
-.nomargin {
-  margin: 0px auto;
-}
-</style>
-<script id="myWorker" type="text/worker">
-self.onmessage = function(e) {
-  var transferredOffscreenCanvas = e.data;
-  var gl = transferredOffscreenCanvas.getContext("webgl");
-  gl.clearColor(1.0, 0.0, 0.0, 1.0);
-  gl.clear(gl.COLOR_BUFFER_BIT);
-  gl.commit();
-};
-</script>
-<script>
-var g_swapsBeforeAck = 15;
-
-function makeWorker(script) {
-   var blob = new Blob([script]);
-   return new Worker(URL.createObjectURL(blob));
-}
-
-function main()
-{
-  draw();
-  waitForFinish();
-}
-
-function draw()
-{
-  var canvas = document.getElementById("c");
-  var offscreenCanvas = canvas.transferControlToOffscreen();
-  var worker = makeWorker(document.getElementById("myWorker").textContent);
-  worker.postMessage(offscreenCanvas, [offscreenCanvas]);
-}
-
-function waitForFinish()
-{
-  if (g_swapsBeforeAck == 0) {
-    domAutomationController.setAutomationId(1);
-    domAutomationController.send("SUCCESS");
-  } else {
-    g_swapsBeforeAck--;
-    document.getElementById('container').style.zIndex = g_swapsBeforeAck + 1;
-    window.webkitRequestAnimationFrame(waitForFinish);
-  }
-}
-</script>
-</head>
-<body onload="main()">
-<div style="position:relative; width:200px; height:200px;
background-color:white">
-</div>
-<div id="container" style="position:absolute; top:0px; left:0px">
-<canvas id="c" width="200" height="200" class="nomargin"></canvas>
-</div>
-</body>
-</html>

Powered by Google App Engine
This is Rietveld 408576698