Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2359193002:
Fix a minor error in content_browser_manifest.json (Closed)
|
Created:
4 years, 3 months ago by xidachen Modified:
4 years, 3 months ago CC:
Aaron Boodman, abarth-chromium, chromium-reviews, danakj, darin (slow to review), darin-cc_chromium.org, jam, Justin Novosad, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xlai (Olivia), yzshen+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix a minor error in content_browser_manifest.json
In a previous CL:https://codereview.chromium.org/2259903002, this CL
adds some interface to be white-listed, it includes
blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is
recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider.
This CL makes that change.
TBR=ben@chromium.org
Committed: https://crrev.com/53531c3fbc0672c0b2b5bc2a6f3fc3944c2c8200
Cr-Commit-Position: refs/heads/master@{#420361}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
xidachen@chromium.org changed reviewers: + ben@chromium.org, piman@chromium.org, rockot@chromium.org
PTAL. This change will make OffscreenCanvas's commit() flow for WebGL working as expected.
The CQ bit was checked by xidachen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM - please feel free to TBR ben and land this
On 2016/09/22 15:04:37, Ken Rockot wrote: > LGTM - please feel free to TBR ben and land this Thank you so much Ken.
kbr@chromium.org changed reviewers: + kbr@chromium.org
Wow. Was an error being generated anywhere when the flaky test from https://codereview.chromium.org/2358833002/ failed? Why did that test become flaky, instead of failing reliably?
On 2016/09/22 15:12:29, Ken Russell wrote: > Wow. > > Was an error being generated anywhere when the flaky test from > https://codereview.chromium.org/2358833002/ failed? > > Why did that test become flaky, instead of failing reliably? Ken, when I run that pixel test this morning, it is failing 100% of the time, not flaky. I thought it was flaky when I first looking at the bots, but apparently it is always failing. I will make sure that it is not flaky locally by repeating this test after this CL lands.
On 2016/09/22 15:12:29, Ken Russell wrote: > Wow. > > Was an error being generated anywhere when the flaky test from > https://codereview.chromium.org/2358833002/ failed? Also, I looked at the stdout from the bots, apparent there is this warning message: [940:2688:0922/061646:ERROR:interface_registry.cc(93)] Capability spec prevented service: exe:content_renderer from binding interface: blink::mojom::OffscreenCanvasCompositorFrameSinkProvider It is saying that this interface cannot be found, but it is not crashing anything.
On 2016/09/22 15:15:02, xidachen wrote: > On 2016/09/22 15:12:29, Ken Russell wrote: > > Wow. > > > > Was an error being generated anywhere when the flaky test from > > https://codereview.chromium.org/2358833002/ failed? > > > > Why did that test become flaky, instead of failing reliably? > > Ken, when I run that pixel test this morning, it is failing 100% of the time, > not flaky. I thought it was flaky when I first looking at the bots, but > apparently it is always failing. I will make sure that it is not flaky locally > by repeating this test after this CL lands. I see. The CQ should have caught the broken test, but unfortunately your CL https://codereview.chromium.org/2358833002/ and Ben's original CL https://codereview.chromium.org/2259903002 collided. Ben's CL landed at r420257. Your CL was tested on linux_chromium_rel_ng in https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... at r420231.
Description was changed from ========== Fix a minor error in content_browser_manifest.json In a previous CL:https://codereview.chromium.org/2259903002, this CL adds some interface to be white-listed, it includes blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider. This CL makes that change. ========== to ========== Fix a minor error in content_browser_manifest.json In a previous CL:https://codereview.chromium.org/2259903002, this CL adds some interface to be white-listed, it includes blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider. This CL makes that change. TBR=ben@chromium.org ==========
xidachen@chromium.org changed reviewers: - ben@chromium.org
The CQ bit was unchecked by xidachen@chromium.org
The CQ bit was checked by xidachen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix a minor error in content_browser_manifest.json In a previous CL:https://codereview.chromium.org/2259903002, this CL adds some interface to be white-listed, it includes blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider. This CL makes that change. TBR=ben@chromium.org ========== to ========== Fix a minor error in content_browser_manifest.json In a previous CL:https://codereview.chromium.org/2259903002, this CL adds some interface to be white-listed, it includes blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider. This CL makes that change. TBR=ben@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix a minor error in content_browser_manifest.json In a previous CL:https://codereview.chromium.org/2259903002, this CL adds some interface to be white-listed, it includes blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider. This CL makes that change. TBR=ben@chromium.org ========== to ========== Fix a minor error in content_browser_manifest.json In a previous CL:https://codereview.chromium.org/2259903002, this CL adds some interface to be white-listed, it includes blink::mojom::OffscreenCanvasFrameReceiver. However, this interface is recently renamed to blink::mojom::OffscreenCanvasCompositorFrameSinkProvider. This CL makes that change. TBR=ben@chromium.org Committed: https://crrev.com/53531c3fbc0672c0b2b5bc2a6f3fc3944c2c8200 Cr-Commit-Position: refs/heads/master@{#420361} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/53531c3fbc0672c0b2b5bc2a6f3fc3944c2c8200 Cr-Commit-Position: refs/heads/master@{#420361} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
