content/test/gpu/gpu_tests/pixel_expectations.py - Issue 2358833002: Update pixel test expectation and add new worker tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/gpu/gpu_tests/pixel_expectations.py

Issue 2358833002: Update pixel test expectation and add new worker tests (Closed)

Patch Set: include newly added file Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html ('K') | « content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html ('k') | content/test/gpu/page_sets/pixel_tests.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from gpu_tests.gpu_test_expectations import GpuTestExpectations	5 from gpu_tests.gpu_test_expectations import GpuTestExpectations

6	6

7 # See the GpuTestExpectations class for documentation.	7 # See the GpuTestExpectations class for documentation.

8	8

9 class PixelExpectations(GpuTestExpectations):	9 class PixelExpectations(GpuTestExpectations):

10 def SetExpectations(self):	10 def SetExpectations(self):

(...skipping 14 matching lines...) Expand all Loading...
25 self.Fail('Pixel.CSS3DBlueBoxES3', ['mac'], bug=533690)	25 self.Fail('Pixel.CSS3DBlueBoxES3', ['mac'], bug=533690)

26	26

27 # TODO(vmiura) check / generate reference images for Android devices	27 # TODO(vmiura) check / generate reference images for Android devices

28 self.Fail('Pixel.SolidColorBackground', ['mac', 'android'], bug=624256)	28 self.Fail('Pixel.SolidColorBackground', ['mac', 'android'], bug=624256)

29	29

30 # TODO(erikchen) check / generate reference images.	30 # TODO(erikchen) check / generate reference images.

31 self.Fail('Pixel.CSSFilterEffects', ['mac'], bug=581526)	31 self.Fail('Pixel.CSSFilterEffects', ['mac'], bug=581526)

32 self.Fail('Pixel.CSSFilterEffects.NoOverlays', ['mac'], bug=581526)	32 self.Fail('Pixel.CSSFilterEffects.NoOverlays', ['mac'], bug=581526)

33	33

34 # TODO(xidachen) check / generate reference images	34 # TODO(xidachen) check / generate reference images

35 self.Fail('Pixel.OffscreenCanvasWebGLGreenBox', bug=563852)	35 self.Fail('Pixel.OffscreenCanvasWebGLRedBoxWorker', bug=563852)

36 self.Fail('Pixel.OffscreenCanvasWebGLGreenBoxES3', ['mac'], bug=563852)	36 self.Fail('Pixel.OffscreenCanvasWebGLRedBoxWorkerES3', ['mac'], bug=563852)
	Justin Novosad 2016/09/21 17:23:21 What is going on here. Are the old tests passing n What is going on here. Are the old tests passing now? xidachen 2016/09/21 17:50:17 Yes. The way pixel test works is like this: 1. Wri Show quoted text On 2016/09/21 17:23:21, Justin Novosad wrote: > What is going on here. Are the old tests passing now? Yes. The way pixel test works is like this: 1. Write a new test, mark it as failure, land the patch 2. GPU bots will run the test, generate reference images and store them on cloud. 3. Once all bots have generated the reference images, remove this failure entry. Because the bots will use the images stored on cloud as reference images. I checked the reference image, and the results on win, linux and android is as expected. But on mac it is giving me a black box on white background, instead of a green box on white background. I have to dig into that. Anyway, in my opinion, that should not necessary block this CL.
OLD	NEW