Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2356293002: Subzero, MIPS32: Instruction NOR, pseudoinstruction NOT (Closed)

Created:
4 years, 3 months ago by obucinac
Modified:
4 years, 3 months ago
CC:
native-client-reviews_googlegroups.com, rich_fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero, MIPS32: Instruction NOR, pseudoinstruction NOT These two are prerequisites for some intrinsic calls and bitwise operations. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cadda79e96a56c043f20dfd0730ccba3636c4e2a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/IceAssemblerMIPS32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerMIPS32.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/IceInstMIPS32.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M src/IceInstMIPS32.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
obucinac
4 years, 3 months ago (2016-09-21 16:34:12 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/2356293002/diff/1/src/IceInstMIPS32.h File src/IceInstMIPS32.h (right): https://codereview.chromium.org/2356293002/diff/1/src/IceInstMIPS32.h#newcode1239 src/IceInstMIPS32.h:1239: template <> void InstMIPS32Abs_d::emitIAS(const Cfg *Func) const; Please add ...
4 years, 3 months ago (2016-09-22 13:52:51 UTC) #4
obucinac
https://codereview.chromium.org/2356293002/diff/1/src/IceInstMIPS32.h File src/IceInstMIPS32.h (right): https://codereview.chromium.org/2356293002/diff/1/src/IceInstMIPS32.h#newcode1239 src/IceInstMIPS32.h:1239: template <> void InstMIPS32Abs_d::emitIAS(const Cfg *Func) const; On 2016/09/22 ...
4 years, 3 months ago (2016-09-22 15:16:53 UTC) #5
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-09-22 18:24:38 UTC) #6
Jim Stichnoth
4 years, 3 months ago (2016-09-22 18:24:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cadda79e96a56c043f20dfd0730ccba3636c4e2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698