Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3415)

Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, ntp-dev+reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ViewHostMsg_CreateWindow to mojom BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+834 lines, -221 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 3 chunks +37 lines, -37 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 4 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/page_state_serialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/render_message_filter.mojom View 1 1 chunk +74 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +0 lines, -76 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/common/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/common/referrer.typemap View 1 1 chunk +8 lines, -0 lines 0 comments Download
A content/public/common/referrer_struct_traits.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A content/public/common/typemaps.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/window_container_type.h View 1 1 chunk +11 lines, -13 lines 0 comments Download
M content/public/common/window_container_type.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A content/public/common/window_container_type.mojom View 1 chunk +18 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 5 chunks +14 lines, -9 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 5 chunks +42 lines, -12 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 3 chunks +20 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 6 chunks +28 lines, -29 lines 0 comments Download
M content/test/test_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/blink_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/PRESUBMIT.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 3 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/ReferrerPolicyEnumTraits.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebStringMojoStringTraits.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebVectorMojoArrayTraits.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/referrer.mojom View 1 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/referrer_policy.typemap View 1 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/public/public_typemaps.gni View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/OWNERS View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/WindowFeaturesStructTraits.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/window_features.mojom View 1 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/window_features.typemap View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
M ui/base/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A ui/base/typemaps.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/base/window_open_disposition.h View 1 chunk +0 lines, -2 lines 0 comments Download
A ui/base/window_open_disposition.mojom View 1 chunk +24 lines, -0 lines 0 comments Download
A ui/base/window_open_disposition.typemap View 1 chunk +8 lines, -0 lines 0 comments Download
A ui/base/window_open_disposition_enum_traits.h View 1 chunk +83 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (2 generated)
Ken Rockot(use gerrit already)
Description was changed from ========== Move ViewHostMsg_CreateWindow to mojom Takes care of several dependencies as ...
3 years, 10 months ago (2016-09-20 23:56:36 UTC) #1
Ken Rockot(use gerrit already)
3 years, 10 months ago (2016-09-21 21:13:43 UTC) #2
Description was changed from

==========
Move ViewHostMsg_CreateWindow to mojom

Takes care of several dependencies as well:

 - Adds mojom and typemap for ui::WindowOpenDisposition
 - Adds mojom and typemap for content::Referrer
 - Adds mojom and typemap for content::WindowContainerType
 - Adds mojom and typemap for blink::WebReferrerPolicy

 - TODO - Window features

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move ViewHostMsg_CreateWindow to mojom

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698