Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 #include "content/browser/web_contents/web_contents_view_guest.h" 75 #include "content/browser/web_contents/web_contents_view_guest.h"
76 #include "content/browser/webui/generic_handler.h" 76 #include "content/browser/webui/generic_handler.h"
77 #include "content/browser/webui/web_ui_controller_factory_registry.h" 77 #include "content/browser/webui/web_ui_controller_factory_registry.h"
78 #include "content/browser/webui/web_ui_impl.h" 78 #include "content/browser/webui/web_ui_impl.h"
79 #include "content/common/browser_plugin/browser_plugin_constants.h" 79 #include "content/common/browser_plugin/browser_plugin_constants.h"
80 #include "content/common/browser_plugin/browser_plugin_messages.h" 80 #include "content/common/browser_plugin/browser_plugin_messages.h"
81 #include "content/common/frame_messages.h" 81 #include "content/common/frame_messages.h"
82 #include "content/common/input_messages.h" 82 #include "content/common/input_messages.h"
83 #include "content/common/page_messages.h" 83 #include "content/common/page_messages.h"
84 #include "content/common/page_state_serialization.h" 84 #include "content/common/page_state_serialization.h"
85 #include "content/common/render_message_filter.mojom.h"
85 #include "content/common/site_isolation_policy.h" 86 #include "content/common/site_isolation_policy.h"
86 #include "content/common/view_messages.h" 87 #include "content/common/view_messages.h"
87 #include "content/public/browser/ax_event_notification_details.h" 88 #include "content/public/browser/ax_event_notification_details.h"
88 #include "content/public/browser/browser_context.h" 89 #include "content/public/browser/browser_context.h"
89 #include "content/public/browser/browser_plugin_guest_manager.h" 90 #include "content/public/browser/browser_plugin_guest_manager.h"
90 #include "content/public/browser/content_browser_client.h" 91 #include "content/public/browser/content_browser_client.h"
91 #include "content/public/browser/devtools_agent_host.h" 92 #include "content/public/browser/devtools_agent_host.h"
92 #include "content/public/browser/download_manager.h" 93 #include "content/public/browser/download_manager.h"
93 #include "content/public/browser/download_url_parameters.h" 94 #include "content/public/browser/download_url_parameters.h"
94 #include "content/public/browser/invalidate_type.h" 95 #include "content/public/browser/invalidate_type.h"
(...skipping 1892 matching lines...) Expand 10 before | Expand all | Expand 10 after
1987 WasShown(); 1988 WasShown();
1988 else if (!visible) 1989 else if (!visible)
1989 WasHidden(); 1990 WasHidden();
1990 } 1991 }
1991 1992
1992 void WebContentsImpl::CreateNewWindow( 1993 void WebContentsImpl::CreateNewWindow(
1993 SiteInstance* source_site_instance, 1994 SiteInstance* source_site_instance,
1994 int32_t route_id, 1995 int32_t route_id,
1995 int32_t main_frame_route_id, 1996 int32_t main_frame_route_id,
1996 int32_t main_frame_widget_route_id, 1997 int32_t main_frame_widget_route_id,
1997 const ViewHostMsg_CreateWindow_Params& params, 1998 const mojom::CreateWindowParams& params,
1998 SessionStorageNamespace* session_storage_namespace) { 1999 SessionStorageNamespace* session_storage_namespace) {
1999 // We usually create the new window in the same BrowsingInstance (group of 2000 // We usually create the new window in the same BrowsingInstance (group of
2000 // script-related windows), by passing in the current SiteInstance. However, 2001 // script-related windows), by passing in the current SiteInstance. However,
2001 // if the opener is being suppressed (in a non-guest), we create a new 2002 // if the opener is being suppressed (in a non-guest), we create a new
2002 // SiteInstance in its own BrowsingInstance. 2003 // SiteInstance in its own BrowsingInstance.
2003 bool is_guest = BrowserPluginGuest::IsGuest(this); 2004 bool is_guest = BrowserPluginGuest::IsGuest(this);
2004 2005
2005 // If the opener is to be suppressed, the new window can be in any process. 2006 // If the opener is to be suppressed, the new window can be in any process.
2006 // Since routing ids are process specific, we must not have one passed in 2007 // Since routing ids are process specific, we must not have one passed in
2007 // as argument here. 2008 // as argument here.
(...skipping 3224 matching lines...) Expand 10 before | Expand all | Expand 10 after
5232 dialog_manager_ = dialog_manager; 5233 dialog_manager_ = dialog_manager;
5233 } 5234 }
5234 5235
5235 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) { 5236 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
5236 auto it = binding_sets_.find(interface_name); 5237 auto it = binding_sets_.find(interface_name);
5237 if (it != binding_sets_.end()) 5238 if (it != binding_sets_.end())
5238 binding_sets_.erase(it); 5239 binding_sets_.erase(it);
5239 } 5240 }
5240 5241
5241 } // namespace content 5242 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698