third_party/WebKit/PRESUBMIT.py - Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/PRESUBMIT.py

diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py

index c385157250137e77a50f2f4711ed988f3c5acb39..030099cc632bbe8ef4477a2589b7452bbb95765c 100644

--- a/third_party/WebKit/PRESUBMIT.py

+++ b/third_party/WebKit/PRESUBMIT.py

@@ -22,7 +22,7 @@ def _CheckForNonBlinkVariantMojomIncludes(input_api, output_api):

for f in input_api.AffectedFiles():

for line_num, line in f.ChangedContents():

m = pattern.match(line)

- if m and m.group(1) != '-blink':

+ if m and m.group(1) != '-blink' and m.group(1) != '-shared':

errors.append(' %s:%d %s' % (

f.LocalPath(), line_num, line))