Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(33)

Issue 2351333002: Move ViewHostMsg_GenerateRoutingID to mojom (Closed)

Created:
2 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
2 years ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ViewHostMsg_GenerateRoutingID to mojom BUG=612500 R=jam@chromium.org, tsepez@chromium.org Committed: https://crrev.com/e261d211c2cc511d905712c082e9b6025ea79197 Cr-Commit-Position: refs/heads/master@{#420180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + content/common/render_message_filter.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Tom Sepez
lgtm
2 years, 8 months ago (2016-09-20 20:18:42 UTC) #3
jam
lgtm
2 years, 8 months ago (2016-09-21 20:30:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351333002/1
2 years, 8 months ago (2016-09-21 20:40:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 8 months ago (2016-09-21 22:23:01 UTC) #9
commit-bot: I haz the power
2 years, 8 months ago (2016-09-21 22:25:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e261d211c2cc511d905712c082e9b6025ea79197
Cr-Commit-Position: refs/heads/master@{#420180}

Powered by Google App Engine
This is Rietveld 408576698