content/browser/frame_host/interstitial_page_impl.cc - Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/interstitial_page_impl.cc

diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc

index 8097c3705bcd0e6f47058b15647feaf2284a3f04..f62ba99c3615a01ae4984303c927efb5753a9b26 100644

--- a/content/browser/frame_host/interstitial_page_impl.cc

+++ b/content/browser/frame_host/interstitial_page_impl.cc

@@ -740,7 +740,7 @@ void InterstitialPageImpl::CreateNewWindow(

int32_t route_id,

int32_t main_frame_route_id,

int32_t main_frame_widget_route_id,

- const ViewHostMsg_CreateWindow_Params& params,

+ const mojom::CreateWindowParams& params,

SessionStorageNamespace* session_storage_namespace) {

NOTREACHED() << "InterstitialPage does not support showing popups yet.";

}