Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/security_exploit_browsertest.cc
diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc
index 2463c00c86d8fca326bf7726512cd8f1c3e2b3b9..2f47ed5fd3ac43888ffc5ee64b393084fa8a71f8 100644
--- a/content/browser/security_exploit_browsertest.cc
+++ b/content/browser/security_exploit_browsertest.cc
@@ -18,6 +18,7 @@
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/frame_messages.h"
+#include "content/common/render_message_filter.mojom.h"
#include "content/common/resource_messages.h"
#include "content/common/resource_request.h"
#include "content/common/view_messages.h"
@@ -259,7 +260,6 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest,
// Since this test executes on the UI thread and hopping threads might cause
// different timing in the test, let's simulate a CreateNewWindow call coming
// from the IO thread.
- ViewHostMsg_CreateWindow_Params params;
DOMStorageContextWrapper* dom_storage_context =
static_cast<DOMStorageContextWrapper*>(
BrowserContext::GetStoragePartition(
@@ -273,7 +273,8 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest,
// RenderViewHostImpl has-a RenderWidgetHostImpl. https://crbug.com/545684
int32_t main_frame_widget_routing_id = duplicate_routing_id;
pending_rvh->CreateNewWindow(duplicate_routing_id, main_frame_routing_id,
- main_frame_widget_routing_id, params,
+ main_frame_widget_routing_id,
+ mojom::CreateWindowParams(),
session_storage.get());
// If the above operation doesn't cause a crash, the test has succeeded!
« no previous file with comments | « content/browser/renderer_host/render_widget_helper.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698