[Extensions] Consolidate ExtensionFunction::SendResponse()s

[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
Committed: https://crrev.com/eedb95b1a034bb392ed83e84ee690395a0db3e27
Cr-Commit-Position: refs/heads/master@{#419955}

[Devlin, 2016-09-20 00:54:42]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 00:55:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:06:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2016-09-20 16:46:06]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:46:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 17:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:43:56]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-20 18:18:54]

Description was changed from

==========
foo

BUG=
==========

to

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
==========

[Devlin, 2016-09-20 18:18:54]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-09-20 18:19:17]

Mind taking a quick look?

[lazyboy, 2016-09-20 20:21:33]

https://codereview.chromium.org/2351823004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_manager/private_api_base.h (right):

https://codereview.chromium.org/2351823004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_manager/private_api_base.h:22: // very
slow. See the implementation of SendResponse() for details.
s/SendResponse/OnResponded?

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
File extensions/browser/extension_function.cc (right):

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
extensions/browser/extension_function.cc:472: void
ExtensionFunction::OnRespondingLater(ResponseValue value) {
Is OnRespondingLater used still? (I can't find any caller to this).

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
File extensions/browser/extension_function.h (right):

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
extensions/browser/extension_function.h:400: // Called after thre response is
sent, allowing the function to perform any
s/thre/the

[Devlin, 2016-09-20 21:46:26]

Description was changed from

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
==========

to

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
==========

[Devlin, 2016-09-20 21:51:05]

https://codereview.chromium.org/2351823004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_manager/private_api_base.h (right):

https://codereview.chromium.org/2351823004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_manager/private_api_base.h:22: // very
slow. See the implementation of SendResponse() for details.
On 2016/09/20 20:21:33, lazyboy wrote:
> s/SendResponse/OnResponded?

Done.

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
File extensions/browser/extension_function.cc (right):

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
extensions/browser/extension_function.cc:472: void
ExtensionFunction::OnRespondingLater(ResponseValue value) {
On 2016/09/20 20:21:33, lazyboy wrote:
> Is OnRespondingLater used still? (I can't find any caller to this).

Looks like no - good catch!

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
File extensions/browser/extension_function.h (right):

https://codereview.chromium.org/2351823004/diff/20001/extensions/browser/exte...
extensions/browser/extension_function.h:400: // Called after thre response is
sent, allowing the function to perform any
On 2016/09/20 20:21:33, lazyboy wrote:
> s/thre/the

Done.

[lazyboy, 2016-09-21 01:10:53]

missed your response, lgtm.

[Devlin, 2016-09-21 01:28:11]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 01:29:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 02:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:24:11]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-21 02:35:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:35:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 02:41:34]

Description was changed from

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
==========

to

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
==========

[commit-bot: I haz the power, 2016-09-21 02:41:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 02:43:56]

Description was changed from

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275
==========

to

==========
[Extensions] Consolidate ExtensionFunction::SendResponse()s

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275

Committed: https://crrev.com/eedb95b1a034bb392ed83e84ee690395a0db3e27
Cr-Commit-Position: refs/heads/master@{#419955}
==========

[commit-bot: I haz the power, 2016-09-21 02:43:57]

Patchset 3 (id:??) landed as
https://crrev.com/eedb95b1a034bb392ed83e84ee690395a0db3e27
Cr-Commit-Position: refs/heads/master@{#419955}