chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc - Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s (Closed)

Patch Set: lazyboy's Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/terminal/terminal_private_api.cc ('k') | chrome/browser/extensions/chrome_extension_function.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc b/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

index 00e0a6f2290e24f4aa182e28996e2df739b11671..50ea3fc88208a7e9812a98b0b8ad4e4625e4c46d 100644

--- a/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

@@ -105,10 +105,7 @@ void WebstoreWidgetPrivateInstallWebstoreItemFunction::OnInstallComplete(

bool success,

const std::string& error,

extensions::webstore_install::Result result) {

- if (!success)

- SetError(error);

- SendResponse(success);

+ Respond(success ? NoArguments() : Error(error));

}

} // namespace api