Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s (Closed)
Patch Set: lazyboy's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc
diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
index a60623839edd34122085e174afa6344e4e1b1c76..2015b7e32c3fc21d7ceb83e5fd9dab6d40c6a0ca 100644
--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc
+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
@@ -166,12 +166,10 @@ TerminalPrivateSendInputFunction::~TerminalPrivateSendInputFunction() {}
void TerminalPrivateOpenTerminalProcessFunction::RespondOnUIThread(
int terminal_id) {
if (terminal_id < 0) {
- SetError("Failed to open process.");
- SendResponse(false);
+ Respond(Error("Failed to open process."));
return;
}
- SetResult(base::MakeUnique<base::FundamentalValue>(terminal_id));
- SendResponse(true);
+ Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(terminal_id)));
}
ExtensionFunction::ResponseAction TerminalPrivateSendInputFunction::Run() {
@@ -198,8 +196,7 @@ void TerminalPrivateSendInputFunction::SendInputOnFileThread(
}
void TerminalPrivateSendInputFunction::RespondOnUIThread(bool success) {
- SetResult(base::MakeUnique<base::FundamentalValue>(success));
- SendResponse(true);
+ Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success)));
}
TerminalPrivateCloseTerminalProcessFunction::
@@ -233,8 +230,7 @@ void TerminalPrivateCloseTerminalProcessFunction::CloseOnFileThread(
void TerminalPrivateCloseTerminalProcessFunction::RespondOnUIThread(
bool success) {
- SetResult(base::MakeUnique<base::FundamentalValue>(success));
- SendResponse(true);
+ Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success)));
}
TerminalPrivateOnTerminalResizeFunction::
@@ -267,8 +263,7 @@ void TerminalPrivateOnTerminalResizeFunction::OnResizeOnFileThread(
}
void TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread(bool success) {
- SetResult(base::MakeUnique<base::FundamentalValue>(success));
- SendResponse(true);
+ Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success)));
}
TerminalPrivateAckOutputFunction::~TerminalPrivateAckOutputFunction() {}

Powered by Google App Engine
This is Rietveld 408576698