Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s (Closed)
Patch Set: lazyboy's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/terminal/terminal_private_api.h" 5 #include "chrome/browser/extensions/api/terminal/terminal_private_api.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 159
160 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE, 160 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
161 base::Bind(callback, terminal_id)); 161 base::Bind(callback, terminal_id));
162 } 162 }
163 163
164 TerminalPrivateSendInputFunction::~TerminalPrivateSendInputFunction() {} 164 TerminalPrivateSendInputFunction::~TerminalPrivateSendInputFunction() {}
165 165
166 void TerminalPrivateOpenTerminalProcessFunction::RespondOnUIThread( 166 void TerminalPrivateOpenTerminalProcessFunction::RespondOnUIThread(
167 int terminal_id) { 167 int terminal_id) {
168 if (terminal_id < 0) { 168 if (terminal_id < 0) {
169 SetError("Failed to open process."); 169 Respond(Error("Failed to open process."));
170 SendResponse(false);
171 return; 170 return;
172 } 171 }
173 SetResult(base::MakeUnique<base::FundamentalValue>(terminal_id)); 172 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(terminal_id)));
174 SendResponse(true);
175 } 173 }
176 174
177 ExtensionFunction::ResponseAction TerminalPrivateSendInputFunction::Run() { 175 ExtensionFunction::ResponseAction TerminalPrivateSendInputFunction::Run() {
178 std::unique_ptr<SendInput::Params> params(SendInput::Params::Create(*args_)); 176 std::unique_ptr<SendInput::Params> params(SendInput::Params::Create(*args_));
179 EXTENSION_FUNCTION_VALIDATE(params.get()); 177 EXTENSION_FUNCTION_VALIDATE(params.get());
180 178
181 // Registry lives on the FILE thread. 179 // Registry lives on the FILE thread.
182 content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE, 180 content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
183 base::Bind(&TerminalPrivateSendInputFunction::SendInputOnFileThread, 181 base::Bind(&TerminalPrivateSendInputFunction::SendInputOnFileThread,
184 this, params->pid, params->input)); 182 this, params->pid, params->input));
185 return RespondLater(); 183 return RespondLater();
186 } 184 }
187 185
188 void TerminalPrivateSendInputFunction::SendInputOnFileThread( 186 void TerminalPrivateSendInputFunction::SendInputOnFileThread(
189 int terminal_id, 187 int terminal_id,
190 const std::string& text) { 188 const std::string& text) {
191 bool success = 189 bool success =
192 chromeos::ProcessProxyRegistry::Get()->SendInput(terminal_id, text); 190 chromeos::ProcessProxyRegistry::Get()->SendInput(terminal_id, text);
193 191
194 content::BrowserThread::PostTask( 192 content::BrowserThread::PostTask(
195 content::BrowserThread::UI, FROM_HERE, 193 content::BrowserThread::UI, FROM_HERE,
196 base::Bind(&TerminalPrivateSendInputFunction::RespondOnUIThread, this, 194 base::Bind(&TerminalPrivateSendInputFunction::RespondOnUIThread, this,
197 success)); 195 success));
198 } 196 }
199 197
200 void TerminalPrivateSendInputFunction::RespondOnUIThread(bool success) { 198 void TerminalPrivateSendInputFunction::RespondOnUIThread(bool success) {
201 SetResult(base::MakeUnique<base::FundamentalValue>(success)); 199 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success)));
202 SendResponse(true);
203 } 200 }
204 201
205 TerminalPrivateCloseTerminalProcessFunction:: 202 TerminalPrivateCloseTerminalProcessFunction::
206 ~TerminalPrivateCloseTerminalProcessFunction() {} 203 ~TerminalPrivateCloseTerminalProcessFunction() {}
207 204
208 ExtensionFunction::ResponseAction 205 ExtensionFunction::ResponseAction
209 TerminalPrivateCloseTerminalProcessFunction::Run() { 206 TerminalPrivateCloseTerminalProcessFunction::Run() {
210 std::unique_ptr<CloseTerminalProcess::Params> params( 207 std::unique_ptr<CloseTerminalProcess::Params> params(
211 CloseTerminalProcess::Params::Create(*args_)); 208 CloseTerminalProcess::Params::Create(*args_));
212 EXTENSION_FUNCTION_VALIDATE(params.get()); 209 EXTENSION_FUNCTION_VALIDATE(params.get());
(...skipping 13 matching lines...) Expand all
226 bool success = 223 bool success =
227 chromeos::ProcessProxyRegistry::Get()->CloseProcess(terminal_id); 224 chromeos::ProcessProxyRegistry::Get()->CloseProcess(terminal_id);
228 225
229 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE, 226 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
230 base::Bind(&TerminalPrivateCloseTerminalProcessFunction:: 227 base::Bind(&TerminalPrivateCloseTerminalProcessFunction::
231 RespondOnUIThread, this, success)); 228 RespondOnUIThread, this, success));
232 } 229 }
233 230
234 void TerminalPrivateCloseTerminalProcessFunction::RespondOnUIThread( 231 void TerminalPrivateCloseTerminalProcessFunction::RespondOnUIThread(
235 bool success) { 232 bool success) {
236 SetResult(base::MakeUnique<base::FundamentalValue>(success)); 233 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success)));
237 SendResponse(true);
238 } 234 }
239 235
240 TerminalPrivateOnTerminalResizeFunction:: 236 TerminalPrivateOnTerminalResizeFunction::
241 ~TerminalPrivateOnTerminalResizeFunction() {} 237 ~TerminalPrivateOnTerminalResizeFunction() {}
242 238
243 ExtensionFunction::ResponseAction 239 ExtensionFunction::ResponseAction
244 TerminalPrivateOnTerminalResizeFunction::Run() { 240 TerminalPrivateOnTerminalResizeFunction::Run() {
245 std::unique_ptr<OnTerminalResize::Params> params( 241 std::unique_ptr<OnTerminalResize::Params> params(
246 OnTerminalResize::Params::Create(*args_)); 242 OnTerminalResize::Params::Create(*args_));
247 EXTENSION_FUNCTION_VALIDATE(params.get()); 243 EXTENSION_FUNCTION_VALIDATE(params.get());
(...skipping 12 matching lines...) Expand all
260 int height) { 256 int height) {
261 bool success = chromeos::ProcessProxyRegistry::Get()->OnTerminalResize( 257 bool success = chromeos::ProcessProxyRegistry::Get()->OnTerminalResize(
262 terminal_id, width, height); 258 terminal_id, width, height);
263 259
264 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE, 260 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
265 base::Bind(&TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread, 261 base::Bind(&TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread,
266 this, success)); 262 this, success));
267 } 263 }
268 264
269 void TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread(bool success) { 265 void TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread(bool success) {
270 SetResult(base::MakeUnique<base::FundamentalValue>(success)); 266 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success)));
271 SendResponse(true);
272 } 267 }
273 268
274 TerminalPrivateAckOutputFunction::~TerminalPrivateAckOutputFunction() {} 269 TerminalPrivateAckOutputFunction::~TerminalPrivateAckOutputFunction() {}
275 270
276 ExtensionFunction::ResponseAction TerminalPrivateAckOutputFunction::Run() { 271 ExtensionFunction::ResponseAction TerminalPrivateAckOutputFunction::Run() {
277 std::unique_ptr<AckOutput::Params> params(AckOutput::Params::Create(*args_)); 272 std::unique_ptr<AckOutput::Params> params(AckOutput::Params::Create(*args_));
278 EXTENSION_FUNCTION_VALIDATE(params.get()); 273 EXTENSION_FUNCTION_VALIDATE(params.get());
279 274
280 content::WebContents* caller_contents = GetSenderWebContents(); 275 content::WebContents* caller_contents = GetSenderWebContents();
281 if (!caller_contents) 276 if (!caller_contents)
(...skipping 13 matching lines...) Expand all
295 params->pid)); 290 params->pid));
296 291
297 return RespondNow(NoArguments()); 292 return RespondNow(NoArguments());
298 } 293 }
299 294
300 void TerminalPrivateAckOutputFunction::AckOutputOnFileThread(int terminal_id) { 295 void TerminalPrivateAckOutputFunction::AckOutputOnFileThread(int terminal_id) {
301 chromeos::ProcessProxyRegistry::Get()->AckOutput(terminal_id); 296 chromeos::ProcessProxyRegistry::Get()->AckOutput(terminal_id);
302 } 297 }
303 298
304 } // namespace extensions 299 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698