Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4874)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_base.h

Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s (Closed)
Patch Set: lazyboy's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/private_api_base.h
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_base.h b/chrome/browser/chromeos/extensions/file_manager/private_api_base.h
index 929d35829467dd74f52f08250677cc702e339cfc..35cdc5cfc9bb139785705d5f8db6aa6c5a5ed738 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_base.h
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_base.h
@@ -19,7 +19,7 @@ namespace extensions {
// By default, logging is turned off, hence sub classes should call
// set_log_on_completion(true) to enable it, if they want. However, even if
// the logging is turned off, a warning is emitted when a function call is
-// very slow. See the implementation of SendResponse() for details.
+// very slow. See the implementation of OnResponded() for details.
class LoggedAsyncExtensionFunction : public ChromeAsyncExtensionFunction {
public:
LoggedAsyncExtensionFunction();
@@ -28,7 +28,7 @@ class LoggedAsyncExtensionFunction : public ChromeAsyncExtensionFunction {
~LoggedAsyncExtensionFunction() override;
// AsyncExtensionFunction overrides.
- void SendResponse(bool success) override;
+ void OnResponded() override;
// Sets the logging on completion flag. By default, logging is turned off.
void set_log_on_completion(bool log_on_completion) {
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698