Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_base.cc

Issue 2351823004: [Extensions] Consolidate ExtensionFunction::SendResponse()s (Closed)
Patch Set: lazyboy's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_base.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_base.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "chrome/browser/chromeos/extensions/file_manager/private_api_util.h" 10 #include "chrome/browser/chromeos/extensions/file_manager/private_api_util.h"
11 #include "components/drive/event_logger.h" 11 #include "components/drive/event_logger.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 namespace { 14 namespace {
15 15
16 const int kSlowOperationThresholdMs = 500; // In ms. 16 const int kSlowOperationThresholdMs = 500; // In ms.
17 17
18 } // namespace 18 } // namespace
19 19
20 LoggedAsyncExtensionFunction::LoggedAsyncExtensionFunction() 20 LoggedAsyncExtensionFunction::LoggedAsyncExtensionFunction()
21 : log_on_completion_(false) { 21 : log_on_completion_(false) {
22 start_time_ = base::Time::Now(); 22 start_time_ = base::Time::Now();
23 } 23 }
24 24
25 LoggedAsyncExtensionFunction::~LoggedAsyncExtensionFunction() { 25 LoggedAsyncExtensionFunction::~LoggedAsyncExtensionFunction() {
26 } 26 }
27 27
28 void LoggedAsyncExtensionFunction::SendResponse(bool success) { 28 void LoggedAsyncExtensionFunction::OnResponded() {
29 drive::EventLogger* logger = file_manager::util::GetLogger(GetProfile()); 29 drive::EventLogger* logger = file_manager::util::GetLogger(GetProfile());
30 if (logger) { 30 if (logger) {
31 int64_t elapsed = (base::Time::Now() - start_time_).InMilliseconds(); 31 int64_t elapsed = (base::Time::Now() - start_time_).InMilliseconds();
32 DCHECK(response_type());
33 bool success = *response_type() == SUCCEEDED;
32 if (log_on_completion_) { 34 if (log_on_completion_) {
33 logger->Log(logging::LOG_INFO, "%s[%d] %s. (elapsed time: %sms)", name(), 35 logger->Log(logging::LOG_INFO, "%s[%d] %s. (elapsed time: %sms)", name(),
34 request_id(), success ? "succeeded" : "failed", 36 request_id(), success ? "succeeded" : "failed",
35 base::Int64ToString(elapsed).c_str()); 37 base::Int64ToString(elapsed).c_str());
36 } else if (elapsed >= kSlowOperationThresholdMs) { 38 } else if (elapsed >= kSlowOperationThresholdMs) {
37 logger->Log(logging::LOG_WARNING, 39 logger->Log(logging::LOG_WARNING,
38 "PEFORMANCE WARNING: %s[%d] was slow. (elapsed time: %sms)", 40 "PEFORMANCE WARNING: %s[%d] was slow. (elapsed time: %sms)",
39 name(), request_id(), base::Int64ToString(elapsed).c_str()); 41 name(), request_id(), base::Int64ToString(elapsed).c_str());
40 } 42 }
41 } 43 }
42 ChromeAsyncExtensionFunction::SendResponse(success); 44 ChromeAsyncExtensionFunction::OnResponded();
43 } 45 }
44 46
45 } // namespace extensions 47 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698