Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes (Closed)

Created:
4 years, 3 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
Devlin, *hirono, *Jamie
CC:
chromium-reviews, extensions-reviews_chromium.org, oka+watch_chromium.org, chromoting-reviews_chromium.org, yamaguchi+watch_chromium.org, jlklein+watch-closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, rlp+watch_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, fukino+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chrome.metricsPrivate externs and make closure fixes In preparation for moving metricsPrivate to //extensions, re-generate the externs file and fix outdated types. BUG=647397 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/527ef366b461db5dec5c8b1ebbb2d377f06e6ef0 Cr-Commit-Position: refs/heads/master@{#419120}

Patch Set 1 #

Patch Set 2 : Fix remoting browser test #

Patch Set 3 : fix file manager test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -26 lines) Patch
M chrome/browser/resources/google_now/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword/metrics.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/metrics/test.js View 3 chunks +6 lines, -6 lines 0 comments Download
M components/chrome_apps/webstore_widget/app/main.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/base/js/client_session.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/js_proto/chrome_mocks.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/metrics_private.js View 10 chunks +44 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/common/js/metrics_base.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/image_loader/image_loader_client.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/image_loader/image_loader_client_unittest.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
michaelpg
PTAL, thanks! hirono: components/chrome_apps/webstore_widget/app/main.js ui/file_manager/* jamiewalch: remoting/webapp/base/js/client_session.js
4 years, 3 months ago (2016-09-15 20:31:20 UTC) #6
Devlin
lgtm
4 years, 3 months ago (2016-09-15 20:40:45 UTC) #7
michaelpg
jamiewalch: also see updated remoting/webapp/js_proto/chrome_mocks.js
4 years, 3 months ago (2016-09-15 21:31:19 UTC) #11
Jamie
remoting/ LGTM.
4 years, 3 months ago (2016-09-15 23:39:20 UTC) #15
hirono
lgtm
4 years, 3 months ago (2016-09-16 01:08:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346683004/40001
4 years, 3 months ago (2016-09-16 01:10:22 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/130010)
4 years, 3 months ago (2016-09-16 01:17:07 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346683004/40001
4 years, 3 months ago (2016-09-16 06:05:48 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 07:00:29 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 07:04:02 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/527ef366b461db5dec5c8b1ebbb2d377f06e6ef0
Cr-Commit-Position: refs/heads/master@{#419120}

Powered by Google App Engine
This is Rietveld 408576698