components/chrome_apps/webstore_widget/app/main.js - Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/chrome_apps/webstore_widget/app/main.js

Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes (Closed)

Patch Set: fix file manager test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/chrome_apps/webstore_widget/app/main.js

diff --git a/components/chrome_apps/webstore_widget/app/main.js b/components/chrome_apps/webstore_widget/app/main.js

index f0ca4676ec4f5ea5420921b248ecb6dc6cf4ac8c..7b3d789c29e05319c32bea94202d73d301de4136 100644

--- a/components/chrome_apps/webstore_widget/app/main.js

+++ b/components/chrome_apps/webstore_widget/app/main.js

@@ -82,7 +82,7 @@ function createPlatformDelegate(strings) {

var index = (value >= 0 && value < enumSize) ? value : enumSize;

chrome.metricsPrivate.recordValue({

'metricName': 'WebstoreWidgetApp.' + enumName,

- 'type': 'histogram-linear',

+ 'type': chrome.metricsPrivate.MetricTypeType.HISTOGRAM_LINEAR,

'min': 1,

'max': enumSize,

'buckets': enumSize + 1