ui/file_manager/file_manager/common/js/metrics_base.js - Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/common/js/metrics_base.js

Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes (Closed)

Patch Set: fix file manager test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/file_manager/common/js/metrics_base.js

diff --git a/ui/file_manager/file_manager/common/js/metrics_base.js b/ui/file_manager/file_manager/common/js/metrics_base.js

index bf2e2936189ed16d4fe9b40cf0542c9d10ed1511..7d6974f1b96d9c85615509aa6966574af8541b23 100644

--- a/ui/file_manager/file_manager/common/js/metrics_base.js

+++ b/ui/file_manager/file_manager/common/js/metrics_base.js

@@ -161,7 +161,7 @@ metricsBase.recordEnum = function(name, value, opt_validValues) {

// (Source: UMA_HISTOGRAM_ENUMERATION definition in base/metrics/histogram.h)

var metricDescr = {

'metricName': metrics.convertName_(name),

- 'type': 'histogram-linear',

+ 'type': chrome.metricsPrivate.MetricTypeType.HISTOGRAM_LINEAR,

'min': 1,

'max': boundaryValue,

'buckets': boundaryValue