ui/file_manager/image_loader/image_loader_client.js - Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/image_loader/image_loader_client.js

Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes (Closed)

Patch Set: fix file manager test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/image_loader/image_loader_client.js

diff --git a/ui/file_manager/image_loader/image_loader_client.js b/ui/file_manager/image_loader/image_loader_client.js

index e83362ed4ad078b19126f9bb3a312c42b88be12d..7f22d46a045fcf1a65c8ea6cb44073f85df25d63 100644

--- a/ui/file_manager/image_loader/image_loader_client.js

+++ b/ui/file_manager/image_loader/image_loader_client.js

@@ -60,7 +60,7 @@ ImageLoaderClient.getInstance = function() {

ImageLoaderClient.recordBinary = function(name, value) {

chrome.metricsPrivate.recordValue(

{ metricName: 'ImageLoader.Client.' + name,

- type: 'histogram-linear',

+ type: chrome.metricsPrivate.MetricTypeType.HISTOGRAM_LINEAR,

min: 1, // According to histogram.h, this should be 1 for enums.

max: 2, // Maximum should be exclusive.

buckets: 3 }, // Number of buckets: 0, 1 and overflowing 2.