remoting/webapp/base/js/client_session.js - Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/base/js/client_session.js

Issue 2346683004: Update chrome.metricsPrivate externs and make closure fixes (Closed)

Patch Set: fix file manager test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/base/js/client_session.js

diff --git a/remoting/webapp/base/js/client_session.js b/remoting/webapp/base/js/client_session.js

index 623d52e7e0505b36ea7a72be01c43d43d61bbc80..8d02310114fac7717554463c8c645dec3dc76e0c 100644

--- a/remoting/webapp/base/js/client_session.js

+++ b/remoting/webapp/base/js/client_session.js

@@ -603,7 +603,7 @@ function recordState(state) {

var metricDescription = {

metricName: 'Chromoting.Connections',

- type: 'histogram-linear',

+ type: chrome.metricsPrivate.MetricTypeType.HISTOGRAM_LINEAR,

// According to histogram.h, minimum should be 1. Values less than minimum

// end up in the 0th bucket.

min: 1,