Update chrome.metricsPrivate externs and make closure fixes

third_party/closure_compiler/externs/metrics_private.js

Index: third_party/closure_compiler/externs/metrics_private.js
diff --git a/third_party/closure_compiler/externs/metrics_private.js b/third_party/closure_compiler/externs/metrics_private.js
index b2c9ef85dc2271e2f6713ea28331fd414215eb86..bd8c516cf5766d458b42acca33a83f983f7a39cc 100644
--- a/third_party/closure_compiler/externs/metrics_private.js
+++ b/third_party/closure_compiler/externs/metrics_private.js
@@ -1,37 +1,56 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// This file was generated by:
+//   tools/json_schema_compiler/compiler.py.
+// NOTE: The format of types has changed. 'FooType' is now
+//   'chrome.metricsPrivate.FooType'.
+// Please run the closure compiler before committing changes.
+// See https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilation.md
+
 /** @fileoverview Externs generated from namespace: metricsPrivate */
 
 /**
+ * @const
+ */
+chrome.metricsPrivate = {};
+
+/**
+ * @enum {string}
+ * @see https://developer.chrome.com/extensions/metricsPrivate#type-MetricTypeType
+ */
+chrome.metricsPrivate.MetricTypeType = {
+  HISTOGRAM_LOG: 'histogram-log',
+  HISTOGRAM_LINEAR: 'histogram-linear',
+};
+
+/**
  * Describes the type of metric that is to be collected.
  * @typedef {{
  *   metricName: string,
- *   type: string,
+ *   type: !chrome.metricsPrivate.MetricTypeType,
  *   min: number,
  *   max: number,
  *   buckets: number
  * }}
+ * @see https://developer.chrome.com/extensions/metricsPrivate#type-MetricType
  */
-var MetricType;
-
-/**
- * @const
- */
-chrome.metricsPrivate = {};
+chrome.metricsPrivate.MetricType;
 
 /**
  * Returns true if the user opted in to sending crash reports.
- * @param {Function} callback
+ * @param {function(boolean):void} callback
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-getIsCrashReportingEnabled
  */
 chrome.metricsPrivate.getIsCrashReportingEnabled = function(callback) {};
 
 /**
- * Returns the group name chosen for the named trial, or the empty string if
- * the trial does not exist or is not enabled.
+ * Returns the group name chosen for the named trial, or the empty string if the
+ * trial does not exist or is not enabled.
  * @param {string} name
- * @param {Function} callback
+ * @param {function(string):void} callback
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-getFieldTrial
  */
 chrome.metricsPrivate.getFieldTrial = function(name, callback) {};
 
@@ -39,13 +58,15 @@ chrome.metricsPrivate.getFieldTrial = function(name, callback) {};
  * Returns variation parameters for the named trial if available, or undefined
  * otherwise.
  * @param {string} name
- * @param {Function} callback
+ * @param {function(Object):void} callback
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-getVariationParams
  */
 chrome.metricsPrivate.getVariationParams = function(name, callback) {};
 
 /**
  * Records an action performed by the user.
  * @param {string} name
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordUserAction
  */
 chrome.metricsPrivate.recordUserAction = function(name) {};
 
@@ -53,6 +74,7 @@ chrome.metricsPrivate.recordUserAction = function(name) {};
  * Records a percentage value from 1 to 100.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordPercentage
  */
 chrome.metricsPrivate.recordPercentage = function(metricName, value) {};
 
@@ -60,6 +82,7 @@ chrome.metricsPrivate.recordPercentage = function(metricName, value) {};
  * Records a value than can range from 1 to 1,000,000.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordCount
  */
 chrome.metricsPrivate.recordCount = function(metricName, value) {};
 
@@ -67,6 +90,7 @@ chrome.metricsPrivate.recordCount = function(metricName, value) {};
  * Records a value than can range from 1 to 100.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordSmallCount
  */
 chrome.metricsPrivate.recordSmallCount = function(metricName, value) {};
 
@@ -74,6 +98,7 @@ chrome.metricsPrivate.recordSmallCount = function(metricName, value) {};
  * Records a value than can range from 1 to 10,000.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordMediumCount
  */
 chrome.metricsPrivate.recordMediumCount = function(metricName, value) {};
 
@@ -82,6 +107,7 @@ chrome.metricsPrivate.recordMediumCount = function(metricName, value) {};
  * specified in milliseconds.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordTime
  */
 chrome.metricsPrivate.recordTime = function(metricName, value) {};
 
@@ -90,6 +116,7 @@ chrome.metricsPrivate.recordTime = function(metricName, value) {};
  * specified in milliseconds.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordMediumTime
  */
 chrome.metricsPrivate.recordMediumTime = function(metricName, value) {};
 
@@ -98,6 +125,7 @@ chrome.metricsPrivate.recordMediumTime = function(metricName, value) {};
  * specified in milliseconds.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordLongTime
  */
 chrome.metricsPrivate.recordLongTime = function(metricName, value) {};
 
@@ -106,12 +134,14 @@ chrome.metricsPrivate.recordLongTime = function(metricName, value) {};
  * by the |metricName|.
  * @param {string} metricName
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordSparseValue
  */
 chrome.metricsPrivate.recordSparseValue = function(metricName, value) {};
 
 /**
  * Adds a value to the given metric.
- * @param {MetricType} metric
+ * @param {!chrome.metricsPrivate.MetricType} metric
  * @param {number} value
+ * @see https://developer.chrome.com/extensions/metricsPrivate#method-recordValue
  */
 chrome.metricsPrivate.recordValue = function(metric, value) {};