Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23450039: Pass isolate to ScriptValue constructor (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
blink-reviews, Nils Barth (inactive), kenneth.christiansen, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Nate Chapin, do-not-use
Visibility:
Public.

Description

Pass isolate to ScriptValue constructor Pass isolate to ScriptValue constructor to avoid implicit call to v8::Isolate::GetCurrent(). R=haraken BUG=263412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157897

Patch Set 1 #

Patch Set 2 : Rebase on master #

Patch Set 3 : Remove useless member #

Total comments: 7

Patch Set 4 : Improve CustomElementConstructorBuilder and add FIXME comments #

Patch Set 5 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -67 lines) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/IDBBindingUtilities.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/IDBBindingUtilitiesTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M Source/bindings/v8/ScriptEventListener.cpp View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.cpp View 3 chunks +18 lines, -10 lines 0 comments Download
M Source/bindings/v8/ScriptObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptPromise.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverTest.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/ScriptString.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptValue.h View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptValue.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/css/MediaQueryListListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-16 13:55:42 UTC) #1
Justin Novosad
On 2013/09/16 13:55:42, Christophe Dumez wrote: lgtm for modules/imagebitmap
7 years, 3 months ago (2013-09-16 14:02:49 UTC) #2
haraken
LGTM https://codereview.chromium.org/23450039/diff/6001/Source/bindings/v8/CustomElementConstructorBuilder.cpp File Source/bindings/v8/CustomElementConstructorBuilder.cpp (right): https://codereview.chromium.org/23450039/diff/6001/Source/bindings/v8/CustomElementConstructorBuilder.cpp#newcode235 Source/bindings/v8/CustomElementConstructorBuilder.cpp:235: return ScriptValue(m_constructor, v8::Isolate::GetCurrent()); Can't you use m_context->GetIsolate() ? ...
7 years, 3 months ago (2013-09-16 16:39:52 UTC) #3
do-not-use
https://codereview.chromium.org/23450039/diff/6001/Source/bindings/v8/ScriptPromise.h File Source/bindings/v8/ScriptPromise.h (right): https://codereview.chromium.org/23450039/diff/6001/Source/bindings/v8/ScriptPromise.h#newcode60 Source/bindings/v8/ScriptPromise.h:60: : m_promise(promise, v8::Isolate::GetCurrent()) On 2013/09/16 16:39:53, haraken wrote: > ...
7 years, 3 months ago (2013-09-16 20:28:04 UTC) #4
haraken
> I was planning to do this in a follow-up patch (ditto for ScriptString) to ...
7 years, 3 months ago (2013-09-16 23:54:17 UTC) #5
do-not-use
https://codereview.chromium.org/23450039/diff/6001/Source/bindings/v8/CustomElementConstructorBuilder.cpp File Source/bindings/v8/CustomElementConstructorBuilder.cpp (right): https://codereview.chromium.org/23450039/diff/6001/Source/bindings/v8/CustomElementConstructorBuilder.cpp#newcode235 Source/bindings/v8/CustomElementConstructorBuilder.cpp:235: return ScriptValue(m_constructor, v8::Isolate::GetCurrent()); On 2013/09/16 16:39:53, haraken wrote: > ...
7 years, 3 months ago (2013-09-17 06:52:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23450039/15001
7 years, 3 months ago (2013-09-17 06:52:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=5925
7 years, 3 months ago (2013-09-17 08:12:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23450039/28001
7 years, 3 months ago (2013-09-17 09:17:10 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 13:33:49 UTC) #10
Message was sent while issue was closed. 
Change committed as 157897

Powered by Google App Engine
This is Rietveld 408576698