Pass isolate to ScriptValue constructor

Source/bindings/v8/ScriptPromise.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 39 matching lines @@
     {
     }
 
     explicit ScriptPromise(ScriptValue promise)
         : m_promise(promise)
     {
         ASSERT(!m_promise.hasNoValue());
     }
 
     explicit ScriptPromise(v8::Handle<v8::Value> promise)
-        : m_promise(promise)
+        : m_promise(promise, v8::Isolate::GetCurrent())

[haraken, 2013/09/16 16:39:53]

Would it be possible to fix caller sites of ScriptPromise() to pass Isolates, so
that we can avoid calling Isolate::GetCurrent()?

[do-not-use, 2013/09/16 20:28:05]

I was planning to do this in a follow-up patch (ditto for ScriptString) to
reduce patch size. This is a temporary situation. To my knowledge, it does not
make the situation any worse. The GetCurrent() call is merely explicit instead
of implicit.

However, I can do those in the same patch if you wish.

[do-not-use, 2013/09/17 06:52:13]

Added a FIXME comment for now.

     {
         ASSERT(!m_promise.hasNoValue());
     }
 
     bool isObject() const
     {
         return m_promise.isObject();
     }
 
     bool isNull() const
@@ skipping 22 matching lines @@
     }
 
 private:
     ScriptValue m_promise;
 };
 
 } // namespace WebCore
 
 
 #endif // ScriptPromise_h