Source/bindings/tests/results/V8TestObject.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestMediaQueryListListener.cpp ('k') | Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp

index 2a9a0915ed429a19b21e120469c05014a4e45a35..b90e1ffafa5d015df7e918e80ed285f7a71e7b84 100644

--- a/Source/bindings/tests/results/V8TestObject.cpp

+++ b/Source/bindings/tests/results/V8TestObject.cpp

@@ -1698,7 +1698,7 @@ static void anyAttributeAttributeGetterCallback(v8::Local<v8::String> name, cons

static void anyAttributeAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)

{

TestObj* imp = V8TestObject::toNative(info.Holder());

- V8TRYCATCH_VOID(ScriptValue, v, ScriptValue(value));

+ V8TRYCATCH_VOID(ScriptValue, v, ScriptValue(value, info.GetIsolate()));

imp->setAnyAttribute(v);

return;

}

@@ -1727,7 +1727,7 @@ static void callbackFunctionAttributeAttributeGetterCallback(v8::Local<v8::Strin

static void callbackFunctionAttributeAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)

{

TestObj* imp = V8TestObject::toNative(info.Holder());

- V8TRYCATCH_VOID(ScriptValue, v, ScriptValue(value));

+ V8TRYCATCH_VOID(ScriptValue, v, ScriptValue(value, info.GetIsolate()));

imp->setCallbackFunctionAttribute(v);

return;

}

@@ -3984,7 +3984,7 @@ static void callbackFunctionArgumentMethod(const v8::FunctionCallbackInfo<v8::Va

return;

}

TestObj* imp = V8TestObject::toNative(args.Holder());

- V8TRYCATCH_VOID(ScriptValue, function, ScriptValue(args[0]));

+ V8TRYCATCH_VOID(ScriptValue, function, ScriptValue(args[0], args.GetIsolate()));

imp->callbackFunctionArgument(function);

return;