Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: Source/modules/imagebitmap/ImageBitmapFactories.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryListListener.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/imagebitmap/ImageBitmapFactories.cpp
diff --git a/Source/modules/imagebitmap/ImageBitmapFactories.cpp b/Source/modules/imagebitmap/ImageBitmapFactories.cpp
index 14a826955cfce1e6cf72f8ea9fa76e88289b0a38..76ae2684c4b977a173a58addfeb3df5a1f09ec4f 100644
--- a/Source/modules/imagebitmap/ImageBitmapFactories.cpp
+++ b/Source/modules/imagebitmap/ImageBitmapFactories.cpp
@@ -318,8 +318,9 @@ void ImageBitmapFactories::ImageBitmapLoader::loadBlobAsync(ScriptExecutionConte
void ImageBitmapFactories::ImageBitmapLoader::rejectPromise()
{
+ v8::Isolate* isolate = m_scriptState->isolate();
ScriptScope scope(m_scriptState);
- m_resolver->reject(ScriptValue::createNull());
+ m_resolver->reject(ScriptValue(v8::Null(isolate), isolate));
m_factory->didFinishLoading(this);
}
« no previous file with comments | « Source/core/css/MediaQueryListListener.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698