Source/bindings/v8/ScriptCallStackFactory.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptCallStackFactory.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptCallStackFactory.cpp

diff --git a/Source/bindings/v8/ScriptCallStackFactory.cpp b/Source/bindings/v8/ScriptCallStackFactory.cpp

index 6f4187237207b6fb3a8f8b32e983522f233fccee..a21bdc29ba8175be9beb03c26dfc8706171ba7cf 100644

--- a/Source/bindings/v8/ScriptCallStackFactory.cpp

+++ b/Source/bindings/v8/ScriptCallStackFactory.cpp

@@ -140,7 +140,7 @@ PassRefPtr<ScriptArguments> createScriptArguments(const v8::FunctionCallbackInfo

Vector<ScriptValue> arguments;

for (int i = skipArgumentCount; i < v8arguments.Length(); ++i)

- arguments.append(ScriptValue(v8arguments[i]));

+ arguments.append(ScriptValue(v8arguments[i], isolate));

return ScriptArguments::create(state, arguments);

}