Pass isolate to ScriptValue constructor

Source/bindings/v8/CustomElementConstructorBuilder.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 214 matching lines @@
 
 bool CustomElementConstructorBuilder::didRegisterDefinition(CustomElementDefinition* definition) const
 {
     ASSERT(!m_constructor.IsEmpty());
 
     return m_callbacks->setBinding(definition, CustomElementBinding::create(m_context->GetIsolate(), m_prototype, m_wrapperType));
 }
 
 ScriptValue CustomElementConstructorBuilder::bindingsReturnValue() const
 {
-    return ScriptValue(m_constructor);
+    return ScriptValue(m_constructor, v8::Isolate::GetCurrent());

[haraken, 2013/09/16 16:39:53]

Can't you use m_context->GetIsolate() ?

[do-not-use, 2013/09/17 06:52:13]

Done.

 }
 
 bool CustomElementConstructorBuilder::hasValidPrototypeChainFor(WrapperTypeInfo* type) const
 {
     v8::Handle<v8::Object> elementPrototype = V8PerContextData::from(m_context)->prototypeForType(type);
     if (elementPrototype.IsEmpty())
         return false;
 
     v8::Handle<v8::Value> chain = m_prototype;
     while (!chain.IsEmpty() && chain->IsObject()) {
@@ skipping 27 matching lines @@
 
     ExceptionState es(args.GetIsolate());
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
     RefPtr<Element> element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, es);
     if (es.throwIfNeeded())
         return;
     v8SetReturnValueFast(args, element.release(), document);
 }
 
 } // namespace WebCore