Add help link when Bluetooth adapter is off for WebBluetooth chooser

Add help link when Bluetooth adapter is off for WebBluetooth chooser

This CL adds a help link on the WebBluetooth chooser when the Bluetooth
adapter is off. This will help users get more information of how to turn
on Bluetooth.

I uploaded some screenshots on the issue page.

BUG=644168
Committed: https://crrev.com/c1bb01aa41e009f6075c5a87e945496a16976194
Cr-Commit-Position: refs/heads/master@{#421952}

[juncai, 2016-09-16 23:09:03]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:09:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:13:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:13:40]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[juncai, 2016-09-16 23:24:29]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-17 00:05:18]

juncai@chromium.org changed reviewers:
+ jyasskin@chromium.org, sky@chromium.org

[juncai, 2016-09-17 00:05:19]

sky@chromium.org: Please review changes in 
//chrome/browser/ui/views/

jyasskin@chromium.org: Please review changes in 
//chrome/browser/chooser_controller/
//chrome/browser/ui/bluetooth/

[commit-bot: I haz the power, 2016-09-17 00:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 00:23:51]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-18 16:06:27]

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:69:
l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_ADAPTER_OFF));
TURN_ADAPTER_OFF/

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:76:
adapter_off_help_->SetPosition(
Why are you setting the position here? You have a layout manager installed (line
56). Generally the layoutmanager takes care of the position/bounds of the
buttons. If you don't need the layoutmanager, don't install it and instead
override Layout.

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.h (right):

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.h:83: views::Link*
adapter_off_help_;               // Weak.
turn_adapter_off_help_?

[juncai, 2016-09-19 19:47:25]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:48:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-19 19:55:24]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org

[juncai, 2016-09-19 19:55:24]

rsesek@chromium.org: Please review changes in
//chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:69:
l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_ADAPTER_OFF));
On 2016/09/18 16:06:27, sky wrote:
> TURN_ADAPTER_OFF/

Done.

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:76:
adapter_off_help_->SetPosition(
On 2016/09/18 16:06:27, sky wrote:
> Why are you setting the position here? You have a layout manager installed
(line
> 56). Generally the layoutmanager takes care of the position/bounds of the
> buttons. If you don't need the layoutmanager, don't install it and instead
> override Layout.

Done.

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.h (right):

https://codereview.chromium.org/2344133003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.h:83: views::Link*
adapter_off_help_;               // Weak.
On 2016/09/18 16:06:27, sky wrote:
> turn_adapter_off_help_?

Done.

[Robert Sesek, 2016-09-19 20:09:24]

chooser_dialog_cocoa_controller_unittest.mm LGTM

[sky, 2016-09-19 20:12:51]

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:38: class
ChooserContentViewLayout : public views::LayoutManager {
ChooserContentViewLayoutManager.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:55:
gfx::Point(kAdapterOffHelpLinkPadding, kAdapterOffHelpLinkPadding));
Doesn't this result in putting the link on top of the table?

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:60: return
host->GetPreferredSize();
View::GetPreferredSize calls to the LayoutManager::GetPreferredSize. So, this
leads to a cycle.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:63: ~ChooserContentViewLayout()
override {}
This should be right after the constructor.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:69: };
DISALLOW...

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:96: turn_adapter_off_help_ = new
views::Link(
Member initialize to null.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:208:
table_view_->SetVisible(enabled);
You sure you don't want table_parent_ here?

[commit-bot: I haz the power, 2016-09-19 20:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:34:51]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-19 23:08:36]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:08:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-19 23:34:35]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-19 23:35:29]

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:38: class
ChooserContentViewLayout : public views::LayoutManager {
On 2016/09/19 20:12:51, sky wrote:
> ChooserContentViewLayoutManager.

Done.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:55:
gfx::Point(kAdapterOffHelpLinkPadding, kAdapterOffHelpLinkPadding));
On 2016/09/19 20:12:51, sky wrote:
> Doesn't this result in putting the link on top of the table?

Yes, it overlaps the table since we want the link text to look like it is inside
the rectangle that embeds the table view. I attached a screenshot at:
https://bugs.chromium.org/p/chromium/issues/detail?id=644168#c13
When the link shows up, the table view will be invisible, so they will not show
up at the same time.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:60: return
host->GetPreferredSize();
On 2016/09/19 20:12:51, sky wrote:
> View::GetPreferredSize calls to the LayoutManager::GetPreferredSize. So, this
> leads to a cycle.

Done.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:63: ~ChooserContentViewLayout()
override {}
On 2016/09/19 20:12:51, sky wrote:
> This should be right after the constructor.

Done.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:69: };
On 2016/09/19 20:12:51, sky wrote:
> DISALLOW...

Done.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:96: turn_adapter_off_help_ = new
views::Link(
On 2016/09/19 20:12:51, sky wrote:
> Member initialize to null.

Done.

https://codereview.chromium.org/2344133003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:208:
table_view_->SetVisible(enabled);
On 2016/09/19 20:12:51, sky wrote:
> You sure you don't want table_parent_ here?

Since here we still need to show the rectangle that embeds the table view, set
the |table_parent_| invisible makes the rectangle invisible.

[sky, 2016-09-19 23:50:02]

LGTM

[commit-bot: I haz the power, 2016-09-20 01:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:08:52]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-26 16:38:56]

ping jyasskin@.

[Jeffrey Yasskin, 2016-09-26 23:25:08]

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:100: virtual void
OpenAdapterOffHelpUrl() const;
Put this next to the other Open...Url() function. If we want to make it pure,
add a TODO to do that. If not, why not?

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/mock_chooser_controller.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/mock_chooser_controller.h:36:
MOCK_CONST_METHOD0(OpenAdapterOffHelpUrl, void());
Put this next to the other one here too.

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:53:
throbber_->SetBounds((kChooserWidth - kThrobberDiameter) / 2,
Do we need to deal with not getting our preferred width or height?

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:109: SetLayoutManager(new
ChooserContentViewLayoutManager(table_parent, throbber_,
It looked to me like sky@ was suggesting to override View::Layout in
ChooserContentView, not to define a LayoutManager specific to this View.
https://cs.chromium.org/chromium/src/ui/views/view.h?l=381&gs=cpp%253Aviews%2...
has some examples of doing that.

Did that turn out to be the wrong thing to do for some reason? If so, why?

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.cc:785: const char kBluetoothAdapterOffHelpURL[] =
Also next to the other bluetooth chooser URL.

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.h:600: extern const char
kBluetoothAdapterOffHelpURL[];
Put this next to the other Bluetooth Chooser URL.

[juncai, 2016-09-28 22:42:00]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 22:42:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-28 22:45:43]

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:100: virtual void
OpenAdapterOffHelpUrl() const;
On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> Put this next to the other Open...Url() function. If we want to make it pure,
> add a TODO to do that. If not, why not?

Since the WebUSB doesn't use this function, and in order to avoid unnecessary
changes to the WebUSB related code, here it is not pure virtual so that WebUSB
code doesn't need to implement it.

Done.

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/mock_chooser_controller.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/mock_chooser_controller.h:36:
MOCK_CONST_METHOD0(OpenAdapterOffHelpUrl, void());
On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> Put this next to the other one here too.

Done.

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:53:
throbber_->SetBounds((kChooserWidth - kThrobberDiameter) / 2,
On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> Do we need to deal with not getting our preferred width or height?

Done.

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:109: SetLayoutManager(new
ChooserContentViewLayoutManager(table_parent, throbber_,
On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> It looked to me like sky@ was suggesting to override View::Layout in
> ChooserContentView, not to define a LayoutManager specific to this View.
>
https://cs.chromium.org/chromium/src/ui/views/view.h?l=381&gs=cpp%253Aviews%2...
> has some examples of doing that.
> 
> Did that turn out to be the wrong thing to do for some reason? If so, why?

ah, I think I misunderstood the comment.

Done.

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.cc:785: const char kBluetoothAdapterOffHelpURL[] =
On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> Also next to the other bluetooth chooser URL.

Done.

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.h:600: extern const char
kBluetoothAdapterOffHelpURL[];
On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> Put this next to the other Bluetooth Chooser URL.

Done.

[Jeffrey Yasskin, 2016-09-28 23:12:24]

sky, could you double-check ChooserContentView::Layout() to make sure it's right
to avoid the LayoutManager?

LGTM after sky's double-check and the NOTREACHED. Thanks!

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2344133003/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:100: virtual void
OpenAdapterOffHelpUrl() const;
On 2016/09/28 22:45:42, juncai wrote:
> On 2016/09/26 23:25:07, Jeffrey Yasskin wrote:
> > Put this next to the other Open...Url() function. If we want to make it
pure,
> > add a TODO to do that. If not, why not?
> 
> Since the WebUSB doesn't use this function, and in order to avoid unnecessary
> changes to the WebUSB related code, here it is not pure virtual so that WebUSB
> code doesn't need to implement it.

Sounds good, thanks.

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/chooser...
File chrome/browser/chooser_controller/chooser_controller.cc (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/chooser...
chrome/browser/chooser_controller/chooser_controller.cc:70: void
ChooserController::OpenAdapterOffHelpUrl() const {}
Let's put a NOTREACHED() here, since we expect every controller that calls this
function, to override it.

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/chooser_content_view.cc:88: void
ChooserContentView::Layout() {
This is great, thanks!

[commit-bot: I haz the power, 2016-09-28 23:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 23:27:23]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-29 03:32:32]

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/chooser_content_view.cc:96:
gfx::Point(kAdapterOffHelpLinkPadding, kAdapterOffHelpLinkPadding));
It's certainly ok to roll your own layout like this.

I would move the SizeToFit call on 68 here to make it clear you're relying on
that. Once you do that, it's a bit easier to see SizeToFit should really be
passed rect.width() - kAdapaterOffHelpLinkPadding. Maybe 2 *
kAdapterOffHelpLinkPadding.

Also, you'll want to call View::Layout() here as that calls Layout() on the
children, which is likely needed.

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/chooser_content_view.h (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/chooser_content_view.h:28: class ChooserContentView :
public views::View,
Sorry for the random comment, and I hope I didn't review this initially. This
name makes me sad here. ChooserContentView is *way* too generic for this
directory. *SIGH* Please file a bug to move and/or rename.

[juncai, 2016-09-29 21:13:04]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 21:13:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-29 21:14:58]

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/chooser...
File chrome/browser/chooser_controller/chooser_controller.cc (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/chooser...
chrome/browser/chooser_controller/chooser_controller.cc:70: void
ChooserController::OpenAdapterOffHelpUrl() const {}
On 2016/09/28 23:12:23, Jeffrey Yasskin wrote:
> Let's put a NOTREACHED() here, since we expect every controller that calls
this
> function, to override it.

Done.

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/chooser_content_view.cc:96:
gfx::Point(kAdapterOffHelpLinkPadding, kAdapterOffHelpLinkPadding));
On 2016/09/29 03:32:31, sky wrote:
> It's certainly ok to roll your own layout like this.
> 
> I would move the SizeToFit call on 68 here to make it clear you're relying on
> that. Once you do that, it's a bit easier to see SizeToFit should really be
> passed rect.width() - kAdapaterOffHelpLinkPadding. Maybe 2 *
> kAdapterOffHelpLinkPadding.
> 
> Also, you'll want to call View::Layout() here as that calls Layout() on the
> children, which is likely needed.

Done.

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/chooser_content_view.h (right):

https://codereview.chromium.org/2344133003/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/chooser_content_view.h:28: class ChooserContentView :
public views::View,
On 2016/09/29 03:32:31, sky wrote:
> Sorry for the random comment, and I hope I didn't review this initially. This
> name makes me sad here. ChooserContentView is *way* too generic for this
> directory. *SIGH* Please file a bug to move and/or rename.

I filed a bug and added a TODO here. Thanks for the suggestion!

[commit-bot: I haz the power, 2016-09-29 22:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:05:44]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-29 22:12:05]

LGTM

[juncai, 2016-09-29 22:13:43]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-09-29 22:13:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2344133003/#ps120001
(title: "address more comments")

[commit-bot: I haz the power, 2016-09-29 22:14:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:20:39]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-29 22:24:52]

Description was changed from

==========
Add help link when Bluetooth adapter is off for WebBluetooth chooser

This CL adds a help link on the WebBluetooth chooser when the Bluetooth
adapter is off. This will help users get more information of how to turn
on Bluetooth.

I uploaded some screenshots on the issue page.

BUG=644168
==========

to

==========
Add help link when Bluetooth adapter is off for WebBluetooth chooser

This CL adds a help link on the WebBluetooth chooser when the Bluetooth
adapter is off. This will help users get more information of how to turn
on Bluetooth.

I uploaded some screenshots on the issue page.

BUG=644168

Committed: https://crrev.com/c1bb01aa41e009f6075c5a87e945496a16976194
Cr-Commit-Position: refs/heads/master@{#421952}
==========

[commit-bot: I haz the power, 2016-09-29 22:24:54]

Patchset 7 (id:??) landed as
https://crrev.com/c1bb01aa41e009f6075c5a87e945496a16976194
Cr-Commit-Position: refs/heads/master@{#421952}