Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Side by Side Diff: chrome/browser/ui/views/chooser_content_view.cc

Issue 2344133003: Add help link when Bluetooth adapter is off for WebBluetooth chooser (Closed)
Patch Set: address more comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/chooser_content_view.h" 5 #include "chrome/browser/ui/views/chooser_content_view.h"
6 6
7 #include "base/numerics/safe_conversions.h" 7 #include "base/numerics/safe_conversions.h"
8 #include "chrome/grit/generated_resources.h" 8 #include "chrome/grit/generated_resources.h"
9 #include "ui/base/l10n/l10n_util.h" 9 #include "ui/base/l10n/l10n_util.h"
10 #include "ui/base/resource/resource_bundle.h" 10 #include "ui/base/resource/resource_bundle.h"
11 #include "ui/gfx/color_palette.h" 11 #include "ui/gfx/color_palette.h"
12 #include "ui/gfx/geometry/point.h"
13 #include "ui/gfx/geometry/rect.h"
12 #include "ui/gfx/image/image_skia.h" 14 #include "ui/gfx/image/image_skia.h"
13 #include "ui/gfx/paint_vector_icon.h" 15 #include "ui/gfx/paint_vector_icon.h"
14 #include "ui/gfx/vector_icons_public.h" 16 #include "ui/gfx/vector_icons_public.h"
15 #include "ui/resources/grit/ui_resources.h" 17 #include "ui/resources/grit/ui_resources.h"
16 #include "ui/views/controls/link.h" 18 #include "ui/views/controls/link.h"
17 #include "ui/views/controls/styled_label.h" 19 #include "ui/views/controls/styled_label.h"
18 #include "ui/views/controls/table/table_view.h" 20 #include "ui/views/controls/table/table_view.h"
19 #include "ui/views/controls/throbber.h" 21 #include "ui/views/controls/throbber.h"
20 #include "ui/views/layout/fill_layout.h"
21 22
22 namespace { 23 namespace {
23 24
24 const int kChooserWidth = 330; 25 const int kChooserWidth = 330;
25 26
26 const int kChooserHeight = 220; 27 const int kChooserHeight = 220;
27 28
28 const int kThrobberDiameter = 24; 29 const int kThrobberDiameter = 24;
29 30
31 const int kAdapterOffHelpLinkPadding = 5;
32
30 // The lookup table for signal strength level image. 33 // The lookup table for signal strength level image.
31 const int kSignalStrengthLevelImageIds[5] = {IDR_SIGNAL_0_BAR, IDR_SIGNAL_1_BAR, 34 const int kSignalStrengthLevelImageIds[5] = {IDR_SIGNAL_0_BAR, IDR_SIGNAL_1_BAR,
32 IDR_SIGNAL_2_BAR, IDR_SIGNAL_3_BAR, 35 IDR_SIGNAL_2_BAR, IDR_SIGNAL_3_BAR,
33 IDR_SIGNAL_4_BAR}; 36 IDR_SIGNAL_4_BAR};
34 37
35 } // namespace 38 } // namespace
36 39
37 ChooserContentView::ChooserContentView( 40 ChooserContentView::ChooserContentView(
38 views::TableViewObserver* table_view_observer, 41 views::TableViewObserver* table_view_observer,
39 std::unique_ptr<ChooserController> chooser_controller) 42 std::unique_ptr<ChooserController> chooser_controller)
40 : chooser_controller_(std::move(chooser_controller)) { 43 : chooser_controller_(std::move(chooser_controller)) {
41 chooser_controller_->set_view(this); 44 chooser_controller_->set_view(this);
42 std::vector<ui::TableColumn> table_columns; 45 std::vector<ui::TableColumn> table_columns;
43 table_columns.push_back(ui::TableColumn()); 46 table_columns.push_back(ui::TableColumn());
44 table_view_ = new views::TableView( 47 table_view_ = new views::TableView(
45 this, table_columns, 48 this, table_columns,
46 chooser_controller_->ShouldShowIconBeforeText() ? views::ICON_AND_TEXT 49 chooser_controller_->ShouldShowIconBeforeText() ? views::ICON_AND_TEXT
47 : views::TEXT_ONLY, 50 : views::TEXT_ONLY,
48 true /* single_selection */); 51 true /* single_selection */);
49 table_view_->set_select_on_remove(false); 52 table_view_->set_select_on_remove(false);
50 table_view_->SetObserver(table_view_observer); 53 table_view_->SetObserver(table_view_observer);
51 table_view_->SetEnabled(chooser_controller_->NumOptions() > 0); 54 table_view_->SetEnabled(chooser_controller_->NumOptions() > 0);
52 55
53 SetLayoutManager(new views::FillLayout()); 56 table_parent_ = table_view_->CreateParentIfNecessary();
54 views::View* table_parent = table_view_->CreateParentIfNecessary(); 57 AddChildView(table_parent_);
55 AddChildView(table_parent);
56 58
57 throbber_ = new views::Throbber(); 59 throbber_ = new views::Throbber();
58 // Set the throbber in the center of the chooser.
59 throbber_->SetBounds((kChooserWidth - kThrobberDiameter) / 2,
60 (kChooserHeight - kThrobberDiameter) / 2,
61 kThrobberDiameter, kThrobberDiameter);
62 throbber_->SetVisible(false); 60 throbber_->SetVisible(false);
63 AddChildView(throbber_); 61 AddChildView(throbber_);
62
63 turn_adapter_off_help_ = new views::Link(
64 l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_TURN_ADAPTER_OFF));
65 turn_adapter_off_help_->SetHandlesTooltips(false);
66 turn_adapter_off_help_->SetUnderline(false);
67 turn_adapter_off_help_->SetMultiLine(true);
68 turn_adapter_off_help_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
69 turn_adapter_off_help_->set_listener(this);
70 turn_adapter_off_help_->SetVisible(false);
71 AddChildView(turn_adapter_off_help_);
64 } 72 }
65 73
66 ChooserContentView::~ChooserContentView() { 74 ChooserContentView::~ChooserContentView() {
67 chooser_controller_->set_view(nullptr); 75 chooser_controller_->set_view(nullptr);
68 table_view_->SetObserver(nullptr); 76 table_view_->SetObserver(nullptr);
69 table_view_->SetModel(nullptr); 77 table_view_->SetModel(nullptr);
78 turn_adapter_off_help_->set_listener(nullptr);
70 if (discovery_state_) 79 if (discovery_state_)
71 discovery_state_->set_listener(nullptr); 80 discovery_state_->set_listener(nullptr);
72 } 81 }
73 82
74 gfx::Size ChooserContentView::GetPreferredSize() const { 83 gfx::Size ChooserContentView::GetPreferredSize() const {
75 return gfx::Size(kChooserWidth, kChooserHeight); 84 return gfx::Size(kChooserWidth, kChooserHeight);
76 } 85 }
77 86
87 void ChooserContentView::Layout() {
88 gfx::Rect rect(GetContentsBounds());
89 table_parent_->SetBoundsRect(rect);
90 // Set the throbber in the center of the chooser.
91 throbber_->SetBounds((rect.width() - kThrobberDiameter) / 2,
92 (rect.height() - kThrobberDiameter) / 2,
93 kThrobberDiameter, kThrobberDiameter);
94 turn_adapter_off_help_->SetPosition(
95 gfx::Point(kAdapterOffHelpLinkPadding, kAdapterOffHelpLinkPadding));
96 turn_adapter_off_help_->SizeToFit(rect.width() -
97 2 * kAdapterOffHelpLinkPadding);
98 views::View::Layout();
99 }
100
78 int ChooserContentView::RowCount() { 101 int ChooserContentView::RowCount() {
79 // When there are no devices, the table contains a message saying there 102 // When there are no devices, the table contains a message saying there
80 // are no devices, so the number of rows is always at least 1. 103 // are no devices, so the number of rows is always at least 1.
81 return std::max(base::checked_cast<int>(chooser_controller_->NumOptions()), 104 return std::max(base::checked_cast<int>(chooser_controller_->NumOptions()),
82 1); 105 1);
83 } 106 }
84 107
85 base::string16 ChooserContentView::GetText(int row, int column_id) { 108 base::string16 ChooserContentView::GetText(int row, int column_id) {
86 int num_options = base::checked_cast<int>(chooser_controller_->NumOptions()); 109 int num_options = base::checked_cast<int>(chooser_controller_->NumOptions());
87 if (num_options == 0) { 110 if (num_options == 0) {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 table_view_->OnItemsChanged(base::checked_cast<int>(index), 1); 175 table_view_->OnItemsChanged(base::checked_cast<int>(index), 1);
153 UpdateTableView(); 176 UpdateTableView();
154 } 177 }
155 178
156 void ChooserContentView::OnAdapterEnabledChanged(bool enabled) { 179 void ChooserContentView::OnAdapterEnabledChanged(bool enabled) {
157 // No row is selected since the adapter status has changed. 180 // No row is selected since the adapter status has changed.
158 // This will also disable the OK button if it was enabled because 181 // This will also disable the OK button if it was enabled because
159 // of a previously selected row. 182 // of a previously selected row.
160 table_view_->Select(-1); 183 table_view_->Select(-1);
161 UpdateTableView(); 184 UpdateTableView();
162 table_view_->SetVisible(true); 185 table_view_->SetVisible(enabled);
186 turn_adapter_off_help_->SetVisible(!enabled);
163 187
164 throbber_->Stop(); 188 throbber_->Stop();
165 throbber_->SetVisible(false); 189 throbber_->SetVisible(false);
166 190
167 discovery_state_->SetText(chooser_controller_->GetStatus()); 191 discovery_state_->SetText(chooser_controller_->GetStatus());
168 discovery_state_->SetEnabled(enabled); 192 discovery_state_->SetEnabled(enabled);
169 } 193 }
170 194
171 void ChooserContentView::OnRefreshStateChanged(bool refreshing) { 195 void ChooserContentView::OnRefreshStateChanged(bool refreshing) {
172 if (refreshing) { 196 if (refreshing) {
(...skipping 15 matching lines...) Expand all
188 else 212 else
189 throbber_->Stop(); 213 throbber_->Stop();
190 214
191 discovery_state_->SetText(chooser_controller_->GetStatus()); 215 discovery_state_->SetText(chooser_controller_->GetStatus());
192 // When refreshing, disable |discovery_state_| to show it as a text label. 216 // When refreshing, disable |discovery_state_| to show it as a text label.
193 // When complete, enable |discovery_state_| to show it as a link. 217 // When complete, enable |discovery_state_| to show it as a link.
194 discovery_state_->SetEnabled(!refreshing); 218 discovery_state_->SetEnabled(!refreshing);
195 } 219 }
196 220
197 void ChooserContentView::LinkClicked(views::Link* source, int event_flags) { 221 void ChooserContentView::LinkClicked(views::Link* source, int event_flags) {
198 chooser_controller_->RefreshOptions(); 222 if (source == discovery_state_)
223 chooser_controller_->RefreshOptions();
224 else if (source == turn_adapter_off_help_)
225 chooser_controller_->OpenAdapterOffHelpUrl();
226 else
227 NOTREACHED();
199 } 228 }
200 229
201 void ChooserContentView::StyledLabelLinkClicked(views::StyledLabel* label, 230 void ChooserContentView::StyledLabelLinkClicked(views::StyledLabel* label,
202 const gfx::Range& range, 231 const gfx::Range& range,
203 int event_flags) { 232 int event_flags) {
204 chooser_controller_->OpenHelpCenterUrl(); 233 chooser_controller_->OpenHelpCenterUrl();
205 } 234 }
206 235
207 base::string16 ChooserContentView::GetWindowTitle() const { 236 base::string16 ChooserContentView::GetWindowTitle() const {
208 return chooser_controller_->GetTitle(); 237 return chooser_controller_->GetTitle();
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 } 286 }
258 287
259 void ChooserContentView::UpdateTableView() { 288 void ChooserContentView::UpdateTableView() {
260 if (chooser_controller_->NumOptions() == 0) { 289 if (chooser_controller_->NumOptions() == 0) {
261 table_view_->OnModelChanged(); 290 table_view_->OnModelChanged();
262 table_view_->SetEnabled(false); 291 table_view_->SetEnabled(false);
263 } else { 292 } else {
264 table_view_->SetEnabled(true); 293 table_view_->SetEnabled(true);
265 } 294 }
266 } 295 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view.h ('k') | chrome/browser/ui/views/chooser_content_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698