chrome/browser/chooser_controller/chooser_controller.cc - Issue 2344133003: Add help link when Bluetooth adapter is off for WebBluetooth chooser

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chooser_controller/chooser_controller.cc

Issue 2344133003: Add help link when Bluetooth adapter is off for WebBluetooth chooser (Closed)

Patch Set: address more comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chooser_controller/chooser_controller.h ('k') | chrome/browser/chooser_controller/mock_chooser_controller.h » ('j') | chrome/browser/ui/views/chooser_content_view.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/chooser_controller/chooser_controller.h"	5 #include "chrome/browser/chooser_controller/chooser_controller.h"

6	6

7 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "components/url_formatter/elide_url.h"	8 #include "components/url_formatter/elide_url.h"

9 #include "content/public/browser/render_frame_host.h"	9 #include "content/public/browser/render_frame_host.h"

10 #include "content/public/browser/web_contents.h"	10 #include "content/public/browser/web_contents.h"

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 return -1;	59 return -1;

60 }	60 }

61	61

62 bool ChooserController::IsConnected(size_t index) const {	62 bool ChooserController::IsConnected(size_t index) const {

63 return false;	63 return false;

64 }	64 }

65	65

66 bool ChooserController::IsPaired(size_t index) const {	66 bool ChooserController::IsPaired(size_t index) const {

67 return false;	67 return false;

68 }	68 }

	69

	70 void ChooserController::OpenAdapterOffHelpUrl() const {}
	Jeffrey Yasskin 2016/09/28 23:12:23 Let's put a NOTREACHED() here, since we expect eve Let's put a NOTREACHED() here, since we expect every controller that calls this function, to override it. juncai 2016/09/29 21:14:57 Done. Show quoted text On 2016/09/28 23:12:23, Jeffrey Yasskin wrote: > Let's put a NOTREACHED() here, since we expect every controller that calls this > function, to override it. Done.
OLD	NEW