Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/ui/views/chooser_content_view.h

Issue 2344133003: Add help link when Bluetooth adapter is off for WebBluetooth chooser (Closed)
Patch Set: address more comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_CHOOSER_CONTENT_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_CHOOSER_CONTENT_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_CHOOSER_CONTENT_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_CHOOSER_CONTENT_VIEW_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
12 #include "chrome/browser/chooser_controller/chooser_controller.h" 12 #include "chrome/browser/chooser_controller/chooser_controller.h"
13 #include "ui/base/models/table_model.h" 13 #include "ui/base/models/table_model.h"
14 #include "ui/views/controls/link_listener.h" 14 #include "ui/views/controls/link_listener.h"
15 #include "ui/views/controls/styled_label_listener.h" 15 #include "ui/views/controls/styled_label_listener.h"
16 #include "ui/views/view.h" 16 #include "ui/views/view.h"
17 17
18 namespace views { 18 namespace views {
19 class Link; 19 class Link;
20 class StyledLabel; 20 class StyledLabel;
21 class TableView; 21 class TableView;
22 class TableViewObserver; 22 class TableViewObserver;
23 class Throbber; 23 class Throbber;
24 } 24 }
25 25
26 // A bubble or dialog view for choosing among several options in a table. 26 // A bubble or dialog view for choosing among several options in a table.
27 // Used for WebUSB/WebBluetooth device selection for Chrome and extensions. 27 // Used for WebUSB/WebBluetooth device selection for Chrome and extensions.
28 class ChooserContentView : public views::View, 28 class ChooserContentView : public views::View,
sky 2016/09/29 03:32:31 Sorry for the random comment, and I hope I didn't
juncai 2016/09/29 21:14:57 I filed a bug and added a TODO here. Thanks for th
29 public ui::TableModel, 29 public ui::TableModel,
30 public ChooserController::View, 30 public ChooserController::View,
31 public views::LinkListener, 31 public views::LinkListener,
32 public views::StyledLabelListener { 32 public views::StyledLabelListener {
33 public: 33 public:
34 ChooserContentView(views::TableViewObserver* table_view_observer, 34 ChooserContentView(views::TableViewObserver* table_view_observer,
35 std::unique_ptr<ChooserController> chooser_controller); 35 std::unique_ptr<ChooserController> chooser_controller);
36 ~ChooserContentView() override; 36 ~ChooserContentView() override;
37 37
38 // views::View: 38 // views::View:
39 gfx::Size GetPreferredSize() const override; 39 gfx::Size GetPreferredSize() const override;
40 void Layout() override;
40 41
41 // ui::TableModel: 42 // ui::TableModel:
42 int RowCount() override; 43 int RowCount() override;
43 base::string16 GetText(int row, int column_id) override; 44 base::string16 GetText(int row, int column_id) override;
44 void SetObserver(ui::TableModelObserver* observer) override; 45 void SetObserver(ui::TableModelObserver* observer) override;
45 gfx::ImageSkia GetIcon(int row) override; 46 gfx::ImageSkia GetIcon(int row) override;
46 47
47 // ChooserController::View: 48 // ChooserController::View:
48 void OnOptionsInitialized() override; 49 void OnOptionsInitialized() override;
49 void OnOptionAdded(size_t index) override; 50 void OnOptionAdded(size_t index) override;
(...skipping 17 matching lines...) Expand all
67 views::Link* CreateExtraView(); 68 views::Link* CreateExtraView();
68 // Ownership of the view is passed to the caller. 69 // Ownership of the view is passed to the caller.
69 views::StyledLabel* CreateFootnoteView(); 70 views::StyledLabel* CreateFootnoteView();
70 void Accept(); 71 void Accept();
71 void Cancel(); 72 void Cancel();
72 void Close(); 73 void Close();
73 void UpdateTableView(); 74 void UpdateTableView();
74 75
75 views::TableView* table_view_for_test() const { return table_view_; } 76 views::TableView* table_view_for_test() const { return table_view_; }
76 views::Throbber* throbber_for_test() const { return throbber_; } 77 views::Throbber* throbber_for_test() const { return throbber_; }
78 views::Link* turn_adapter_off_help_for_test() const {
79 return turn_adapter_off_help_;
80 }
77 81
78 private: 82 private:
79 std::unique_ptr<ChooserController> chooser_controller_; 83 std::unique_ptr<ChooserController> chooser_controller_;
80 views::TableView* table_view_; // Weak. 84 views::TableView* table_view_ = nullptr; // Weak.
81 views::Throbber* throbber_; // Weak. 85 views::View* table_parent_ = nullptr; // Weak.
82 views::Link* discovery_state_ = nullptr; // Weak. 86 views::Throbber* throbber_ = nullptr; // Weak.
83 views::StyledLabel* styled_label_ = nullptr; // Weak. 87 views::Link* turn_adapter_off_help_ = nullptr; // Weak.
88 views::Link* discovery_state_ = nullptr; // Weak.
89 views::StyledLabel* styled_label_ = nullptr; // Weak.
84 90
85 DISALLOW_COPY_AND_ASSIGN(ChooserContentView); 91 DISALLOW_COPY_AND_ASSIGN(ChooserContentView);
86 }; 92 };
87 93
88 #endif // CHROME_BROWSER_UI_VIEWS_CHOOSER_CONTENT_VIEW_H_ 94 #endif // CHROME_BROWSER_UI_VIEWS_CHOOSER_CONTENT_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698