Add help link when Bluetooth adapter is off for WebBluetooth chooser

chrome/browser/ui/views/chooser_content_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chooser_content_view.h"
 
 #include "base/numerics/safe_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/color_palette.h"
+#include "ui/gfx/geometry/point.h"
+#include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/gfx/vector_icons_public.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/styled_label.h"
 #include "ui/views/controls/table/table_view.h"
 #include "ui/views/controls/throbber.h"
-#include "ui/views/layout/fill_layout.h"
 
 namespace {
 
 const int kChooserWidth = 330;
 
 const int kChooserHeight = 220;
 
 const int kThrobberDiameter = 24;
 
+const int kAdapterOffHelpLinkPadding = 5;
+
 // The lookup table for signal strength level image.
 const int kSignalStrengthLevelImageIds[5] = {IDR_SIGNAL_0_BAR, IDR_SIGNAL_1_BAR,
                                              IDR_SIGNAL_2_BAR, IDR_SIGNAL_3_BAR,
                                              IDR_SIGNAL_4_BAR};
 
 }  // namespace
 
 ChooserContentView::ChooserContentView(
     views::TableViewObserver* table_view_observer,
     std::unique_ptr<ChooserController> chooser_controller)
     : chooser_controller_(std::move(chooser_controller)) {
   chooser_controller_->set_view(this);
   std::vector<ui::TableColumn> table_columns;
   table_columns.push_back(ui::TableColumn());
   table_view_ = new views::TableView(
       this, table_columns,
       chooser_controller_->ShouldShowIconBeforeText() ? views::ICON_AND_TEXT
                                                       : views::TEXT_ONLY,
       true /* single_selection */);
   table_view_->set_select_on_remove(false);
   table_view_->SetObserver(table_view_observer);
   table_view_->SetEnabled(chooser_controller_->NumOptions() > 0);
 
-  SetLayoutManager(new views::FillLayout());
-  views::View* table_parent = table_view_->CreateParentIfNecessary();
-  AddChildView(table_parent);
+  table_parent_ = table_view_->CreateParentIfNecessary();
+  AddChildView(table_parent_);
 
   throbber_ = new views::Throbber();
-  // Set the throbber in the center of the chooser.
-  throbber_->SetBounds((kChooserWidth - kThrobberDiameter) / 2,
-                       (kChooserHeight - kThrobberDiameter) / 2,
-                       kThrobberDiameter, kThrobberDiameter);
   throbber_->SetVisible(false);
   AddChildView(throbber_);
+
+  turn_adapter_off_help_ = new views::Link(
+      l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_TURN_ADAPTER_OFF));
+  turn_adapter_off_help_->SetHandlesTooltips(false);
+  turn_adapter_off_help_->SetUnderline(false);
+  turn_adapter_off_help_->SetMultiLine(true);
+  turn_adapter_off_help_->SizeToFit(kChooserWidth);
+  turn_adapter_off_help_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  turn_adapter_off_help_->set_listener(this);
+  turn_adapter_off_help_->SetVisible(false);
+  AddChildView(turn_adapter_off_help_);
 }
 
 ChooserContentView::~ChooserContentView() {
   chooser_controller_->set_view(nullptr);
   table_view_->SetObserver(nullptr);
   table_view_->SetModel(nullptr);
+  turn_adapter_off_help_->set_listener(nullptr);
   if (discovery_state_)
     discovery_state_->set_listener(nullptr);
 }
 
 gfx::Size ChooserContentView::GetPreferredSize() const {
   return gfx::Size(kChooserWidth, kChooserHeight);
 }
 
+void ChooserContentView::Layout() {

[Jeffrey Yasskin, 2016/09/28 23:12:23]

This is great, thanks!

+  gfx::Rect rect(GetContentsBounds());
+  table_parent_->SetBoundsRect(rect);
+  // Set the throbber in the center of the chooser.
+  throbber_->SetBounds((rect.width() - kThrobberDiameter) / 2,
+                       (rect.height() - kThrobberDiameter) / 2,
+                       kThrobberDiameter, kThrobberDiameter);
+  turn_adapter_off_help_->SetPosition(
+      gfx::Point(kAdapterOffHelpLinkPadding, kAdapterOffHelpLinkPadding));

[sky, 2016/09/29 03:32:31]

It's certainly ok to roll your own layout like this.

I would move the SizeToFit call on 68 here to make it clear you're relying on
that. Once you do that, it's a bit easier to see SizeToFit should really be
passed rect.width() - kAdapaterOffHelpLinkPadding. Maybe 2 *
kAdapterOffHelpLinkPadding.

Also, you'll want to call View::Layout() here as that calls Layout() on the
children, which is likely needed.

[juncai, 2016/09/29 21:14:57]

Done.

+}
+
 int ChooserContentView::RowCount() {
   // When there are no devices, the table contains a message saying there
   // are no devices, so the number of rows is always at least 1.
   return std::max(base::checked_cast<int>(chooser_controller_->NumOptions()),
                   1);
 }
 
 base::string16 ChooserContentView::GetText(int row, int column_id) {
   int num_options = base::checked_cast<int>(chooser_controller_->NumOptions());
   if (num_options == 0) {
@@ skipping 64 matching lines @@
   table_view_->OnItemsChanged(base::checked_cast<int>(index), 1);
   UpdateTableView();
 }
 
 void ChooserContentView::OnAdapterEnabledChanged(bool enabled) {
   // No row is selected since the adapter status has changed.
   // This will also disable the OK button if it was enabled because
   // of a previously selected row.
   table_view_->Select(-1);
   UpdateTableView();
-  table_view_->SetVisible(true);
+  table_view_->SetVisible(enabled);
+  turn_adapter_off_help_->SetVisible(!enabled);
 
   throbber_->Stop();
   throbber_->SetVisible(false);
 
   discovery_state_->SetText(chooser_controller_->GetStatus());
   discovery_state_->SetEnabled(enabled);
 }
 
 void ChooserContentView::OnRefreshStateChanged(bool refreshing) {
   if (refreshing) {
@@ skipping 15 matching lines @@
   else
     throbber_->Stop();
 
   discovery_state_->SetText(chooser_controller_->GetStatus());
   // When refreshing, disable |discovery_state_| to show it as a text label.
   // When complete, enable |discovery_state_| to show it as a link.
   discovery_state_->SetEnabled(!refreshing);
 }
 
 void ChooserContentView::LinkClicked(views::Link* source, int event_flags) {
-  chooser_controller_->RefreshOptions();
+  if (source == discovery_state_)
+    chooser_controller_->RefreshOptions();
+  else if (source == turn_adapter_off_help_)
+    chooser_controller_->OpenAdapterOffHelpUrl();
+  else
+    NOTREACHED();
 }
 
 void ChooserContentView::StyledLabelLinkClicked(views::StyledLabel* label,
                                                 const gfx::Range& range,
                                                 int event_flags) {
   chooser_controller_->OpenHelpCenterUrl();
 }
 
 base::string16 ChooserContentView::GetWindowTitle() const {
   return chooser_controller_->GetTitle();
@@ skipping 48 matching lines @@
 }
 
 void ChooserContentView::UpdateTableView() {
   if (chooser_controller_->NumOptions() == 0) {
     table_view_->OnModelChanged();
     table_view_->SetEnabled(false);
   } else {
     table_view_->SetEnabled(true);
   }
 }