Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2354023003: Add help link when Bluetooth adapter is off for WebBluetooth chooser on Mac (Closed)

Created:
4 years, 3 months ago by juncai
Modified:
4 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add help link when Bluetooth adapter is off for WebBluetooth chooser on Mac This CL adds a help link on the WebBluetooth chooser when the Bluetooth adapter is off on Mac. This will help users get more information of how to turn on Bluetooth. I uploaded some screenshots on the issue page. BUG=644168 Committed: https://crrev.com/4efef78587e43679bd5bdefb4eef0f208119e6b6 Cr-Commit-Position: refs/heads/master@{#421980}

Patch Set 1 : added help link when Bluetooth adapter is off for WebBluetooth chooser on Mac #

Patch Set 2 : updated test code #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.h View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 1 2 3 11 chunks +42 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 1 2 3 9 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
juncai
Please take a look. Thanks!
4 years, 3 months ago (2016-09-20 23:11:27 UTC) #6
Robert Sesek
LGTM
4 years, 3 months ago (2016-09-21 17:14:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354023003/60001
4 years, 2 months ago (2016-09-29 23:27:11 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-29 23:34:51 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 23:37:27 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4efef78587e43679bd5bdefb4eef0f208119e6b6
Cr-Commit-Position: refs/heads/master@{#421980}

Powered by Google App Engine
This is Rietveld 408576698