Display Histograms in value-set-table-cells.

Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/6W2a0wVjAxi.png

Value-set-table is still the only consumer of histogram-span, so this patch takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
Histogram-level diagnostics are also now displayed in histogram-span.

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/741024c90dcebf63dca8b815c519a548b6c6f9c7

[benjhayden, 2016-09-16 02:59:40]

Description was changed from

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table,
and we should be able to see multiple histograms at once.
==========

to

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
==========

[benjhayden, 2016-09-16 04:52:39]

Description was changed from

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
==========

to

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
==========

[benjhayden, 2016-09-16 05:03:35]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-09-16 05:03:39]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2016-09-16 05:03:44]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2016-09-16 05:03:47]

Patchset #1 (id:60001) has been deleted

[benjhayden, 2016-09-16 05:05:16]

Description was changed from

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
==========

to

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.

Screenshot: https://screenshot.googleplex.com/BUApJVWMcRH.png
==========

[benjhayden, 2016-09-16 05:05:25]

Description was changed from

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.

Screenshot: https://screenshot.googleplex.com/BUApJVWMcRH.png
==========

to

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.

Screenshot (google-only): https://screenshot.googleplex.com/BUApJVWMcRH.png
==========

[benjhayden, 2016-09-16 05:06:47]

Description was changed from

==========
[value-set-table] histograms in cells

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.

Screenshot (google-only): https://screenshot.googleplex.com/BUApJVWMcRH.png
==========

to

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.

Screenshot (google-only): https://screenshot.googleplex.com/BUApJVWMcRH.png
==========

[benjhayden, 2016-09-16 05:13:58]

Patchset #1 (id:80001) has been deleted

[benjhayden, 2016-09-16 05:19:09]

Description was changed from

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.
Histogram-level diagnostics are also now displayed in histogram-span.
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.

Screenshot (google-only): https://screenshot.googleplex.com/BUApJVWMcRH.png
==========

to

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/BUApJVWMcRH.png

This CL demonstrates how many places would need to set font-size:initial in
order to
override tr-ui-b-table's rule setting font-size: 12px. Another CL may try to
remove
that style.

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
TODO Histogram-level diagnostics are also now displayed in histogram-span.

Value-set-table used to be able to store a setting for the last selected
Histogram,
but now that multiple Histograms can be displayed at once, any time you search
or change groupings or toggle Show all, it forgets which Histograms were shown.
==========

[benjhayden, 2016-09-16 05:31:45]

Description was changed from

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/BUApJVWMcRH.png

This CL demonstrates how many places would need to set font-size:initial in
order to
override tr-ui-b-table's rule setting font-size: 12px. Another CL may try to
remove
that style.

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
TODO Histogram-level diagnostics are also now displayed in histogram-span.

Value-set-table used to be able to store a setting for the last selected
Histogram,
but now that multiple Histograms can be displayed at once, any time you search
or change groupings or toggle Show all, it forgets which Histograms were shown.
==========

to

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/Fdd1EzLoRwB.png

This CL demonstrates how many places would need to set font-size:initial in
order to
override tr-ui-b-table's rule setting font-size: 12px. Another CL may try to
remove
that style.

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
TODO Histogram-level diagnostics are also now displayed in histogram-span.

Value-set-table used to be able to store a setting for the last selected
Histogram,
but now that multiple Histograms can be displayed at once, any time you search
or change groupings or toggle Show all, it forgets which Histograms were shown.
==========

[benjhayden, 2016-09-16 05:33:05]

Patchset #1 (id:100001) has been deleted

[benjhayden, 2016-09-16 05:53:30]

Description was changed from

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/Fdd1EzLoRwB.png

This CL demonstrates how many places would need to set font-size:initial in
order to
override tr-ui-b-table's rule setting font-size: 12px. Another CL may try to
remove
that style.

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
TODO Histogram-level diagnostics are also now displayed in histogram-span.

Value-set-table used to be able to store a setting for the last selected
Histogram,
but now that multiple Histograms can be displayed at once, any time you search
or change groupings or toggle Show all, it forgets which Histograms were shown.
==========

to

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/Fdd1EzLoRwB.png

This CL demonstrates how many places would need to set font-size:initial in
order to
override tr-ui-b-table's rule setting font-size: 12px. Another CL may try to
remove
that style.

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
Histogram-level diagnostics are also now displayed in histogram-span.

Value-set-table used to be able to store a setting for the last selected
Histogram,
but now that multiple Histograms can be displayed at once, any time you search
or change groupings or toggle Show all, it forgets which Histograms were shown.
==========

[benjhayden, 2016-09-16 05:53:42]

Patchset #1 (id:120001) has been deleted

[benjhayden, 2016-09-16 05:55:42]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2016-09-16 05:55:42]

PTAL :-)

[nednguyen, 2016-09-16 10:34:14]

On 2016/09/16 05:55:42, benjhayden wrote:
> PTAL :-)

I just want to say that this looks so cool :-)

[nednguyen, 2016-09-16 10:42:09]

On 2016/09/16 10:34:14, nednguyen wrote:
> On 2016/09/16 05:55:42, benjhayden wrote:
> > PTAL :-)
> 
> I just want to say that this looks so cool :-)

I think we need to also update the metric-side-panel, I tried your patch on
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-outpu...
& open metric-side-panel and here is what I get:
https://screenshot.googleplex.com/4nySMO4xhwi.png (Googler only, sorry)

There is a lot of unused whitespace to the right of value-set-table in the
picture

[benjhayden, 2016-09-20 07:16:32]

On 2016/09/16 at 10:42:09, nednguyen wrote:
> On 2016/09/16 10:34:14, nednguyen wrote:
> > On 2016/09/16 05:55:42, benjhayden wrote:
> > > PTAL :-)
> > 
> > I just want to say that this looks so cool :-)
> 
> I think we need to also update the metric-side-panel, I tried your patch on
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-outpu...
& open metric-side-panel and here is what I get:
> https://screenshot.googleplex.com/4nySMO4xhwi.png (Googler only, sorry)
> 
> There is a lot of unused whitespace to the right of value-set-table in the
picture

Thanks!
I think I fixed the unused whitespace.
I still need to display histogram diagnostics in a separate table from sample
diagnostics, fix merging histograms to say new Histogram() then addHistogram
instead of clone(), and add histogram-span.`set reference` to display delta
diagnostics, but this should be ready to review modulo that stuff.

[benjhayden, 2016-09-21 06:54:36]

Yeah, this CL is too big. I'll split it tomorrow.

[eakuefner, 2016-09-21 17:37:33]

lgtm

fix the tests and consider punting the font size stuff

[eakuefner, 2016-09-21 17:38:19]

also, agreed offline that axis labels can totes wait

https://codereview.chromium.org/2341623002/diff/340001/tracing/tracing/base/u...
File tracing/tracing/base/unit.html (right):

https://codereview.chromium.org/2341623002/diff/340001/tracing/tracing/base/u...
tracing/tracing/base/unit.html:60: get unitString() {
TODO: share code?

[benjhayden, 2016-09-21 23:10:45]

Patchset #1 (id:140001) has been deleted

[benjhayden, 2016-09-21 23:10:51]

Patchset #1 (id:160001) has been deleted

[benjhayden, 2016-09-21 23:10:58]

Patchset #1 (id:180001) has been deleted

[benjhayden, 2016-09-21 23:10:59]

Patchset #1 (id:180001) has been deleted

[benjhayden, 2016-09-21 23:31:06]

Description was changed from

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/Fdd1EzLoRwB.png

This CL demonstrates how many places would need to set font-size:initial in
order to
override tr-ui-b-table's rule setting font-size: 12px. Another CL may try to
remove
that style.

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
Histogram-level diagnostics are also now displayed in histogram-span.

Value-set-table used to be able to store a setting for the last selected
Histogram,
but now that multiple Histograms can be displayed at once, any time you search
or change groupings or toggle Show all, it forgets which Histograms were shown.
==========

to

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/6W2a0wVjAxi.png

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
Histogram-level diagnostics are also now displayed in histogram-span.
==========

[benjhayden, 2016-09-21 23:31:14]

Patchset #1 (id:200001) has been deleted

[benjhayden, 2016-09-21 23:31:22]

Patchset #1 (id:220001) has been deleted

[benjhayden, 2016-09-21 23:31:28]

Patchset #1 (id:240001) has been deleted

[benjhayden, 2016-09-21 23:31:30]

Patchset #1 (id:240001) has been deleted

[benjhayden, 2016-09-21 23:31:39]

Patchset #1 (id:260001) has been deleted

[benjhayden, 2016-09-21 23:31:45]

Patchset #1 (id:280001) has been deleted

[benjhayden, 2016-09-21 23:40:55]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-09-21 23:40:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2341623002/#ps460001
(title: ".")

[benjhayden, 2016-09-21 23:41:02]

Patchset #4 (id:360001) has been deleted

[commit-bot: I haz the power, 2016-09-21 23:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benjhayden, 2016-09-21 23:41:10]

Patchset #1 (id:300001) has been deleted

[commit-bot: I haz the power, 2016-09-22 00:10:02]

Description was changed from

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/6W2a0wVjAxi.png

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
Histogram-level diagnostics are also now displayed in histogram-span.
==========

to

==========
Display Histograms in value-set-table-cells.

Currently, value-set-table displays a single histogram below the table.
This histogram is below the fold when there are many rows in the table.
Histograms, their statistics, diagnostics, and sample diagnostics should all be
in the value-set-table's cells.

This patch adds a dom-module tr-v-ui-value-set-table-cell that manages the
transitions between scalar-span and histogram-span.

Screenshot (google-only): https://screenshot.googleplex.com/6W2a0wVjAxi.png

Value-set-table is still the only consumer of histogram-span, so this patch
takes
some liberties with it:
Histogram-span now uses a BarChart instead of a ColumnChart so that bins are
comparable between columns of the value-set-span.
Histogram-level diagnostics are also now displayed in histogram-span.

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-09-22 00:10:04]

Committed patchset #7 (id:460001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...