Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: tracing/tracing/value/ui/value_set_table_test.html

Issue 2341623002: Display Histograms in value-set-table-cells. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/value_set_table.html ('k') | tracing/tracing/value/value_set.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/value_set_table_test.html
diff --git a/tracing/tracing/value/ui/value_set_table_test.html b/tracing/tracing/value/ui/value_set_table_test.html
index 2862c14ce6d4d8d89d4b6fc692fddc4b1d68c5c6..bbc712e311f5924fa981687b9b5abf947d3caee8 100644
--- a/tracing/tracing/value/ui/value_set_table_test.html
+++ b/tracing/tracing/value/ui/value_set_table_test.html
@@ -270,8 +270,10 @@ tr.b.unittest.testSuite(function() {
assert.lengthOf(baseTable.tableColumns, 3);
assert.strictEqual('Name', baseTable.tableColumns[0].title);
- assert.strictEqual('iteration A', baseTable.tableColumns[1].title);
- assert.strictEqual('iteration B', baseTable.tableColumns[2].title);
+ assert.strictEqual('iteration A',
+ baseTable.tableColumns[1].title);
+ assert.strictEqual('iteration B',
+ baseTable.tableColumns[2].title);
});
test('instantiation_mergeNumerics', function() {
@@ -297,8 +299,10 @@ tr.b.unittest.testSuite(function() {
var numeric = new tr.v.Histogram('foo',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,
TEST_BOUNDARIES);
- for (var i = 0; i < 100; ++i)
- numeric.addSample(Math.random() * 1e3);
+ for (var i = 0; i < 100; ++i) {
+ numeric.addSample(Math.random() * 1e3, {
+ sample_diagnostic: new tr.v.d.Generic(i)});
+ }
values.addHistogram(numeric);
@@ -391,14 +395,9 @@ tr.b.unittest.testSuite(function() {
for (var m = 0; m < 2; ++m) {
subRowPath.push(m);
- assert.lengthOf(getSubRow().subRows, 1, subRowPath);
+ assert.lengthOf(getSubRow().subRows, 0, subRowPath);
assert.strictEqual('story repeat ' + m, getSubRow().name,
subRowPath);
-
- subRowPath.push(0);
- assert.strictEqual('iteration', getSubRow().name, subRowPath);
- subRowPath.pop();
-
subRowPath.pop();
}
subRowPath.pop();
« no previous file with comments | « tracing/tracing/value/ui/value_set_table.html ('k') | tracing/tracing/value/value_set.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698